Skip to content

8293466: libjsig should ignore non-modifying sigaction calls#2158

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-b1ed40a8
Closed

8293466: libjsig should ignore non-modifying sigaction calls#2158
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:GoeLin-backport-b1ed40a8

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 2, 2023

A small fix for 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8293466 needs maintainer approval

Issue

  • JDK-8293466: libjsig should ignore non-modifying sigaction calls (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2158/head:pull/2158
$ git checkout pull/2158

Update a local copy of the PR:
$ git checkout pull/2158
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2158

View PR using the GUI difftool:
$ git pr show -t 2158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2158.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b1ed40a87ab357d1b51ac5102bba181f21ffa9b6 8293466: libjsig should ignore non-modifying sigaction calls Oct 2, 2023
@openjdk
Copy link

openjdk bot commented Oct 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 2, 2023
@openjdk
Copy link

openjdk bot commented Oct 2, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Oct 2, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293466: libjsig should ignore non-modifying sigaction calls

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 3, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

Going to push as commit 51a80dd.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 3, 2023
@openjdk openjdk bot closed this Oct 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@GoeLin Pushed as commit 51a80dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant