-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case #2166
Conversation
👋 Welcome back amosshi! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/approval request "Backporting for parity with jdk11.0.21-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass.” |
/approve yes |
@GoeLin |
|
@amosshi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 75b7c79.
Your commit was automatically rebased without conflicts. |
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2166/head:pull/2166
$ git checkout pull/2166
Update a local copy of the PR:
$ git checkout pull/2166
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2166/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2166
View PR using the GUI difftool:
$ git pr show -t 2166
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2166.diff
Webrev
Link to Webrev Comment