Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java #2167

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 5, 2023

Backport of the test exclusion. I had to resolve the problemlist but will mark as clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316710 needs maintainer approval

Issue

  • JDK-8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2167/head:pull/2167
$ git checkout pull/2167

Update a local copy of the PR:
$ git checkout pull/2167
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2167

View PR using the GUI difftool:
$ git pr show -t 2167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2167.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 31422d70d09277d604446a9bccad859c1ae9f3c2 8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/approval request Test exclusion, no risk.

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@RealCLanger
8316710: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316710: Exclude java/awt/font/Rotate/RotatedTextTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 6, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

Going to push as commit 0aba9b7.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2023
@openjdk openjdk bot closed this Oct 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@RealCLanger Pushed as commit 0aba9b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-31422d70 branch October 6, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant