Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308592: Framework for CA interoperability testing #2168

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 7, 2023

Backport of the new Framework for CA interoperability testing to have the same code in all release codelines.

I had to resolve deletion of SSLCA.java and needed to adapt code that was using switch expressions for JDK11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8308592 needs maintainer approval

Issue

  • JDK-8308592: Framework for CA interoperability testing (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2168/head:pull/2168
$ git checkout pull/2168

Update a local copy of the PR:
$ git checkout pull/2168
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2168

View PR using the GUI difftool:
$ git pr show -t 2168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2168.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cb535e2d52221bfc23e4c26a730399bceb573547 8308592: Framework for CA interoperability testing Oct 7, 2023
@openjdk
Copy link

openjdk bot commented Oct 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 7, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@RealCLanger
Copy link
Contributor Author

/approval request We should backport this to have the same set of CA tests through all releases. This will ease problem analysis since issues in these tests are typically the same everywhere. Low risk, test only. Tested in SAP nightlies and GHA.

@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@RealCLanger
8308592: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 10, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 11, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@GoeLin
8308592: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8308592: Framework for CA interoperability testing

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • df5ff37: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 11, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

Going to push as commit c4faab6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • df5ff37: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2023
@openjdk openjdk bot closed this Oct 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@RealCLanger Pushed as commit c4faab6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants