-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308592: Framework for CA interoperability testing #2168
8308592: Framework for CA interoperability testing #2168
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
/approval request We should backport this to have the same set of CA tests through all releases. This will ease problem analysis since issues in these tests are typically the same everywhere. Low risk, test only. Tested in SAP nightlies and GHA. |
@RealCLanger |
/approve yes |
@GoeLin |
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@RealCLanger Pushed as commit c4faab6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of the new Framework for CA interoperability testing to have the same code in all release codelines.
I had to resolve deletion of SSLCA.java and needed to adapt code that was using switch expressions for JDK11.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2168/head:pull/2168
$ git checkout pull/2168
Update a local copy of the PR:
$ git checkout pull/2168
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2168/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2168
View PR using the GUI difftool:
$ git pr show -t 2168
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2168.diff
Webrev
Link to Webrev Comment