Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere #2169

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Oct 9, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8312573 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2169/head:pull/2169
$ git checkout pull/2169

Update a local copy of the PR:
$ git checkout pull/2169
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2169/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2169

View PR using the GUI difftool:
$ git pr show -t 2169

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2169.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6f76b65ace50b2361221dddab120e91b057497c1 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 9, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 11, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 11, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@GoeLin
8312573: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • df5ff37: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 11, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@luchenlin
Your change (at version 4c97a02) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 11, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

Going to push as commit 8336e3e.
Since your change was applied there have been 4 commits pushed to the master branch:

  • a75f34f: 8232933: Javac inferred type does not conform to equality constraint
  • b017f76: 8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify
  • c4faab6: 8308592: Framework for CA interoperability testing
  • df5ff37: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2023
@openjdk openjdk bot closed this Oct 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@GoeLin @luchenlin Pushed as commit 8336e3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants