Skip to content

8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify#2172

Closed
luchenlin wants to merge 3 commits intoopenjdk:masterfrom
luchenlin:andrewLu_backport_8210168
Closed

8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify#2172
luchenlin wants to merge 3 commits intoopenjdk:masterfrom
luchenlin:andrewLu_backport_8210168

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Oct 10, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8210168 needs maintainer approval

Issue

  • JDK-8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2172/head:pull/2172
$ git checkout pull/2172

Update a local copy of the PR:
$ git checkout pull/2172
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2172

View PR using the GUI difftool:
$ git pr show -t 2172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2172.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d36066fdadb281f2cac363f92a22826a4c0b5f65 8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 10, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2023

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 11, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 11, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@GoeLin
8210168: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify

Check for 'bc_length > 0' to handle lengths of -1.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c4faab6: 8308592: Framework for CA interoperability testing
  • df5ff37: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 11, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@luchenlin
Your change (at version 2ed15f4) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 11, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

Going to push as commit b017f76.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c4faab6: 8308592: Framework for CA interoperability testing
  • df5ff37: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2023
@openjdk openjdk bot closed this Oct 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@GoeLin @luchenlin Pushed as commit b017f76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants