8303607: SunMSCAPI provider leaks memory and keys

[macarte]

Backport a393f2581740f854518a3ef7caccd6d3c2d8e4a0

Backporting this to 11 as the issue is still relevant; passes tier1 tests and the fix has been verified in 11/windows

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8303607 needs maintainer approval

Issue

• JDK-8303607: SunMSCAPI provider leaks memory and keys (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2174/head:pull/2174
$ git checkout pull/2174

Update a local copy of the PR:
$ git checkout pull/2174
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2174

View PR using the GUI difftool:
$ git pr show -t 2174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2174.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back macarte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @macarte This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (59c8be9e)

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8303607: The approval request has been approved.

[openjdk]

@macarte This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303607: SunMSCAPI provider leaks memory and keys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 84bc252: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
• efc3f4a: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
• 4780287: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.
• 75b7c79: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
• 6e34daa: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
• 2a39b98: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
• 8336e3e: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
• a75f34f: 8232933: Javac inferred type does not conform to equality constraint
• b017f76: 8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify
• c4faab6: 8308592: Framework for CA interoperability testing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[macarte]

/integrate

[openjdk]

@macarte
Your change (at version 59c8be9) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 94d3648.
Since your change was applied there have been 11 commits pushed to the master branch:

• 363855d: 8233000: Mark vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize test as stress test
• 84bc252: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
• efc3f4a: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
• 4780287: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.
• 75b7c79: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
• 6e34daa: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
• 2a39b98: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
• 8336e3e: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
• a75f34f: 8232933: Javac inferred type does not conform to equality constraint
• b017f76: 8210168: JCK test .vm.classfmt.ins.code__002.code__00201m1.code__00201m1 hangs with -noverify
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/df5ff37ba2059b5931502bccf79e1585e90f35dc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @macarte Pushed as commit 94d3648.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.