8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext

[amosshi]

• Backport for JDK-8255548
• Test succeeded in local dev box

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8255548 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext (Bug - P4 - Approved)

Reviewers

• Goetz Lindenmaier (@GoeLin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2177/head:pull/2177
$ git checkout pull/2177

Update a local copy of the PR:
$ git checkout pull/2177
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2177

View PR using the GUI difftool:
$ git pr show -t 2177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2177.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amosshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (6664bd9a)

[amosshi]

/approval request "Backporting for parity with jdk11.0.21-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass.”

[openjdk]

@amosshi
8255548: The approval request has been created successfully.

[GoeLin]

Adapted Copyright and added @library statement.

[GoeLin]

LGTM

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[amosshi]

/integrate

[openjdk]

@amosshi This pull request has not yet been marked as ready for integration.

[GoeLin]

Hi @amosshi, this is not a clean backport :)
This is the case if no review was needed.

[amosshi]

/integrate

[openjdk]

@amosshi This pull request has not yet been marked as ready for integration.

[openjdk]

⚠️ @amosshi the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8255548
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 281a51f: Merge
• a046767: 8317644: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.21
• 9bdeff7: 8317040: Exclude cleaner test failing on older releases
• cac0ab2: 8286503: Enhance security classes
• 5646389: 8284910: Buffer clean in PasswordCallback
• 43a93cc: 8242330: Arrays should be cloned in several JAAS Callback classes
• e60621f: 8309966: Enhanced TLS connections
• e994cb9: 8297856: Improve handling of Bidi characters
• ead65b4: 8296581: Better system proxy support
• 92a47bc: 8315062: [GHA] get-bootjdk action should return the abolute path
• ... and 28 more: https://git.openjdk.org/jdk11u-dev/compare/a4b30272bc08e3c799183604f0a606e5f526b9ca...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[amosshi]

/integrate

[openjdk]

@amosshi
Your change (at version 6664bd9) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 639afbe.
Since your change was applied there have been 42 commits pushed to the master branch:

• abeacbf: 8299255: Unexpected round errors in FreetypeFontScaler
• d439c4a: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
• 0b60ec7: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
• 21536b0: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
• 281a51f: Merge
• a046767: 8317644: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.21
• 9bdeff7: 8317040: Exclude cleaner test failing on older releases
• cac0ab2: 8286503: Enhance security classes
• 5646389: 8284910: Buffer clean in PasswordCallback
• 43a93cc: 8242330: Arrays should be cloned in several JAAS Callback classes
• ... and 32 more: https://git.openjdk.org/jdk11u-dev/compare/a4b30272bc08e3c799183604f0a606e5f526b9ca...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @amosshi Pushed as commit 639afbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.