8296275: Write a test to verify setAccelerator method of JMenuItem

[amosshi]

• Backport of JDK-8296275
• Test succeeded in local dev box

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8296275 needs maintainer approval

Issue

• JDK-8296275: Write a test to verify setAccelerator method of JMenuItem (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2179/head:pull/2179
$ git checkout pull/2179

Update a local copy of the PR:
$ git checkout pull/2179
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2179

View PR using the GUI difftool:
$ git pr show -t 2179

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2179.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amosshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (80ca651c)

[amosshi]

/approval request "Backporting for parity with 11.0.20-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass.”

[openjdk]

@amosshi
8296275: The approval request has been created successfully.

[openjdk]

⚠️ @amosshi the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8296275
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296275: Write a test to verify setAccelerator  method of JMenuItem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• c780db7: 8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[amosshi]

/integrate

[openjdk]

@amosshi
Your change (at version 80ca651) is now ready to be sponsored by a Committer.

[GoeLin]

/integrate

[openjdk]

@GoeLin Only the author (@amosshi) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 7be6fc2.
Since your change was applied there have been 3 commits pushed to the master branch:

• 3ba3e88: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
• 855efc4: 8311285: report some fontconfig related environment variables in hs_err file
• c780db7: 8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr"

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @amosshi Pushed as commit 7be6fc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.