Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296275: Write a test to verify setAccelerator method of JMenuItem #2179

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Oct 13, 2023

  • Backport of JDK-8296275
  • Test succeeded in local dev box

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8296275 needs maintainer approval

Issue

  • JDK-8296275: Write a test to verify setAccelerator method of JMenuItem (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2179/head:pull/2179
$ git checkout pull/2179

Update a local copy of the PR:
$ git checkout pull/2179
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2179

View PR using the GUI difftool:
$ git pr show -t 2179

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2179.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back amosshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b005013a0015656b7f6ccc26f8a13c44d61f77b9 8296275: Write a test to verify setAccelerator method of JMenuItem Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Oct 16, 2023

/approval request "Backporting for parity with 11.0.20-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass.”

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi
8296275: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

⚠️ @amosshi the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8296275
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8296275: Write a test to verify setAccelerator  method of JMenuItem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c780db7: 8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 16, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Oct 16, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi
Your change (at version 80ca651) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@GoeLin Only the author (@amosshi) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit 7be6fc2.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3ba3e88: 8310549: avoid potential leaks in KeystoreImpl.m related to JNU_CHECK_EXCEPTION early returns
  • 855efc4: 8311285: report some fontconfig related environment variables in hs_err file
  • c780db7: 8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@GoeLin @amosshi Pushed as commit 7be6fc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8296275 branch October 17, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants