Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301167: Update VerifySignedJar to actually exercise and test verification #2185

Closed
wants to merge 2 commits into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Oct 15, 2023


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301167 needs maintainer approval

Issue

  • JDK-8301167: Update VerifySignedJar to actually exercise and test verification (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2185/head:pull/2185
$ git checkout pull/2185

Update a local copy of the PR:
$ git checkout pull/2185
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2185

View PR using the GUI difftool:
$ git pr show -t 2185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2185.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2023

👋 Welcome back amosshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 05ea083b0563ddacf3e38dc329ba00dc4bac9b29 8301167: Update VerifySignedJar to actually exercise and test verification Oct 15, 2023
@openjdk
Copy link

openjdk bot commented Oct 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 15, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@amosshi
Copy link
Contributor Author

amosshi commented Oct 21, 2023

/approval request "Backporting for parity with 11.0.21-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass.”

@openjdk
Copy link

openjdk bot commented Oct 21, 2023

@amosshi
8301167: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 21, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 23, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@GoeLin
8301167: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

⚠️ @amosshi the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8301167b
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301167: Update VerifySignedJar to actually exercise and test verification

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 639afbe: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
  • abeacbf: 8299255: Unexpected round errors in FreetypeFontScaler
  • d439c4a: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
  • 0b60ec7: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
  • 21536b0: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 281a51f: Merge
  • a046767: 8317644: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.21
  • 9bdeff7: 8317040: Exclude cleaner test failing on older releases
  • cac0ab2: 8286503: Enhance security classes
  • 5646389: 8284910: Buffer clean in PasswordCallback
  • ... and 13 more: https://git.openjdk.org/jdk11u-dev/compare/94d3648be11ac80621f1c829618f3e49cc55a3b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 23, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Oct 23, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@amosshi
Your change (at version a56255f) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 25, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

Going to push as commit c922821.
Since your change was applied there have been 29 commits pushed to the master branch:

  • a28f66b: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
  • ce38b3e: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • 2835c6a: 8254711: Add java.security.Provider.getService JFR Event
  • 129e856: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • c124213: 8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog
  • fb8676a: 8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key.
  • 639afbe: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
  • abeacbf: 8299255: Unexpected round errors in FreetypeFontScaler
  • d439c4a: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
  • 0b60ec7: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
  • ... and 19 more: https://git.openjdk.org/jdk11u-dev/compare/94d3648be11ac80621f1c829618f3e49cc55a3b5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2023
@openjdk openjdk bot closed this Oct 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@GoeLin @amosshi Pushed as commit c922821.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8301167b branch November 29, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants