Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311285: report some fontconfig related environment variables in hs_err file #2193

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 16, 2023

Backport of 8311285


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311285 needs maintainer approval

Issue

  • JDK-8311285: report some fontconfig related environment variables in hs_err file (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2193/head:pull/2193
$ git checkout pull/2193

Update a local copy of the PR:
$ git checkout pull/2193
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2193/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2193

View PR using the GUI difftool:
$ git pr show -t 2193

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2193.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0ef03f122866f010ebf50683097e9b92e41cdaad 8311285: report some fontconfig related environment variables in hs_err file Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 16, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8311285: report some fontconfig related environment variables in hs_err file

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 16, 2023
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

Going to push as commit 855efc4.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 17, 2023
@openjdk openjdk bot closed this Oct 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@MBaesken Pushed as commit 855efc4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant