Skip to content

8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SoniaZaldana wants to merge 1 commit into from
Closed

8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java #2194

SoniaZaldana wants to merge 1 commit into from

Conversation

@SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Oct 17, 2023 •
edited by openjdk bot
Loading

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8273803 needs maintainer approval

Issue

  • JDK-8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2194/head:pull/2194
$ git checkout pull/2194

Update a local copy of the PR:
$ git checkout pull/2194
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2194

View PR using the GUI difftool:
$ git pr show -t 2194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2194.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2d13fb21af783ebbe3dd5c2632aea11347317026 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2023 •
edited
Loading

Webrevs

@SoniaZaldana
Copy link
Member Author

SoniaZaldana commented Oct 17, 2023 •
edited
Loading

/approval request "Fix Request 11u. Low risk as it affects tests only. Tests pass with GHA."

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@SoniaZaldana
8273803: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 17, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 18, 2023

Hi @SoniaZaldana, can you please enable Github actions for this repo?
How did you test this PR?

@GoeLin
Copy link
Member

GoeLin commented Oct 23, 2023

Hi @SoniaZaldana, I remove the fix-request label in the JBS issue for now. Once you had a look at above comments, you can label it again.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Oct 23, 2023
@SoniaZaldana SoniaZaldana force-pushed the SoniaZaldana-backport-2d13fb21 branch from d1816ac to 7fd5910 Compare October 23, 2023 15:25
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@SoniaZaldana Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@SoniaZaldana
Copy link
Member Author

SoniaZaldana commented Oct 23, 2023

Hi @GoeLin, I had ran tier 1 and the relevant tests locally. I had a bit of trouble running GHA but it looks like it is working now. Let me know if there is anything else I need to do on my end. Thanks!

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 24, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 25, 2023

/approve yes
Thanks!

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@GoeLin
8273803: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 25, 2023 •
edited
Loading

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java
  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 4245e3c: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • 5c92da0: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU
  • b88668b: 8213926: WB_EnqueueInitializerForCompilation requests compilation for NULL
  • 4b88beb: 8213622: Windows VS2013 build failure - "'snprintf': identifier not found"
  • b9b01c9: 8192864: defmeth tests can hide failures
  • ca2290b: 8208705: [TESTBUG] The -Xlog:cds,cds+hashtables vm option is not always required for appcds tests
  • ae6b8d0: 8208704: runtime/appcds/MultiReleaseJars.java timed out often in hs-tier7 testing
  • bc48a48: 8311511: Improve description of NativeLibrary JFR event
  • ... and 111 more: https://git.openjdk.org/jdk11u-dev/compare/92a47bc70293f85f7020b0dccf18ab29a956d384...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 25, 2023
@GoeLin
Copy link
Member

GoeLin commented Dec 5, 2023

Hi @@SoniaZaldana , what is the status of this change? It is pending for quite a while now.

@SoniaZaldana
Copy link
Member Author

SoniaZaldana commented Dec 5, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@SoniaZaldana
Your change (at version 7fd5910) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 5, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

Going to push as commit 04d2033.
Since your change was applied there have been 121 commits pushed to the master branch:

  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java
  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 4245e3c: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • 5c92da0: 8255546: Missing coverage for javax.smartcardio.CardPermission and ResponseAPDU
  • b88668b: 8213926: WB_EnqueueInitializerForCompilation requests compilation for NULL
  • 4b88beb: 8213622: Windows VS2013 build failure - "'snprintf': identifier not found"
  • b9b01c9: 8192864: defmeth tests can hide failures
  • ca2290b: 8208705: [TESTBUG] The -Xlog:cds,cds+hashtables vm option is not always required for appcds tests
  • ae6b8d0: 8208704: runtime/appcds/MultiReleaseJars.java timed out often in hs-tier7 testing
  • bc48a48: 8311511: Improve description of NativeLibrary JFR event
  • ... and 111 more: https://git.openjdk.org/jdk11u-dev/compare/92a47bc70293f85f7020b0dccf18ab29a956d384...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2023
@openjdk openjdk bot closed this Dec 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@jerboaa @SoniaZaldana Pushed as commit 04d2033.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SoniaZaldana @GoeLin @jerboaa