Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog #2196

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Oct 20, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8223788 needs maintainer approval
  • JDK-8153090 needs maintainer approval

Issues

  • JDK-8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog (Bug - P3)
  • JDK-8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key. (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2196/head:pull/2196
$ git checkout pull/2196

Update a local copy of the PR:
$ git checkout pull/2196
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2196

View PR using the GUI difftool:
$ git pr show -t 2196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2196.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5e162200b684897e0ec2547dc2b3f854c0da8e4 8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 20, 2023
@luchenlin
Copy link
Contributor Author

/issue add JDK-8223788

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

@luchenlin
Adding additional issue to issue list: 8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key..

@mlbridge
Copy link

mlbridge bot commented Oct 20, 2023

Webrevs

@luchenlin luchenlin closed this Oct 20, 2023
@luchenlin luchenlin deleted the andrewLu_backport_8153090 branch October 20, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant