Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key. #2199

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Oct 20, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8223788 needs maintainer approval

Issue

  • JDK-8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key. (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2199/head:pull/2199
$ git checkout pull/2199

Update a local copy of the PR:
$ git checkout pull/2199
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2199

View PR using the GUI difftool:
$ git pr show -t 2199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2199.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 861e1addda4a547c319c7b369f042c7aab8bf36f 8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key. Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 639afbe: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
  • abeacbf: 8299255: Unexpected round errors in FreetypeFontScaler
  • d439c4a: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
  • 0b60ec7: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
  • 21536b0: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 281a51f: Merge
  • a046767: 8317644: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.21
  • 9bdeff7: 8317040: Exclude cleaner test failing on older releases
  • cac0ab2: 8286503: Enhance security classes
  • 5646389: 8284910: Buffer clean in PasswordCallback
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/c780db754e14ff77995dc090396d1958cea1ada1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 23, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@luchenlin
Your change (at version 6e24b7b) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 24, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

Going to push as commit fb8676a.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 639afbe: 8255548: Missing coverage for javax.xml.crypto.dom.DOMCryptoContext
  • abeacbf: 8299255: Unexpected round errors in FreetypeFontScaler
  • d439c4a: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
  • 0b60ec7: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
  • 21536b0: 8278456: Define jtreg jdk_desktop test group time-based sub-tasks for use by headful testing.
  • 281a51f: Merge
  • a046767: 8317644: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.21
  • 9bdeff7: 8317040: Exclude cleaner test failing on older releases
  • cac0ab2: 8286503: Enhance security classes
  • 5646389: 8284910: Buffer clean in PasswordCallback
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/c780db754e14ff77995dc090396d1958cea1ada1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2023
@openjdk openjdk bot closed this Oct 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@GoeLin @luchenlin Pushed as commit fb8676a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants