Skip to content

8273804: Platform.isTieredSupported should handle the no-compiler case #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tabjy
Copy link
Member

@tabjy tabjy commented Oct 20, 2023

a clean backport of JDK-8273804.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8273804 needs maintainer approval

Issue

  • JDK-8273804: Platform.isTieredSupported should handle the no-compiler case (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2201/head:pull/2201
$ git checkout pull/2201

Update a local copy of the PR:
$ git checkout pull/2201
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2201

View PR using the GUI difftool:
$ git pr show -t 2201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2201.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2023

👋 Welcome back kxu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 46af82e5b0d176e340f46125f8a3bb17e56bd7b3 8273804: Platform.isTieredSupported should handle the no-compiler case Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2023

⚠️ @tabjy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2023

Webrevs

@tabjy tabjy closed this Oct 20, 2023
Backport-of: 46af82e5b0d176e340f46125f8a3bb17e56bd7b3
@tabjy tabjy reopened this Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tabjy Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@tabjy
Copy link
Member Author

tabjy commented Oct 23, 2023

/approval Fix Request jdk11u
Applies cleanly. Low risk for test-only fixes. No test failures.

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tabjy usage: /approval [<id>] (request|cancel) [<text>]

@tabjy
Copy link
Member Author

tabjy commented Oct 23, 2023

/approval request Fix Request jdk11u
Applies cleanly. Low risk for test-only fixes. No test failures.

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tabjy
8273804: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 23, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 23, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@GoeLin
8273804: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tabjy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273804: Platform.isTieredSupported should handle the no-compiler case

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 23, 2023
@tabjy
Copy link
Member Author

tabjy commented Oct 23, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@tabjy
Your change (at version 204e96a) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 25, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

Going to push as commit ce38b3e.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 2835c6a: 8254711: Add java.security.Provider.getService JFR Event
  • 129e856: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • c124213: 8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog
  • fb8676a: 8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2023
@openjdk openjdk bot closed this Oct 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@GoeLin @tabjy Pushed as commit ce38b3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants