-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region #2204
Conversation
👋 Welcome back sunny868! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
/approval request Fix Request 11u |
Please be a bit more elaborate in you approval request. You should mention reason, risk and testing. |
/approval request Fix Request jdk11u |
Well, ok... tier1 is a bare minimum of tests, and run by the GHA anyways. GC changes should be tested more intensely, it's a major component of the JVM. |
|
@sunny868 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
I have already make run-test for tire2-3 for x86_84 locally. I check failed items are not related to this patch. ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier2 325 325 0 0 >> jtreg:test/jdk:tier2 3477 3466 10 1 << jtreg:test/langtools:tier2 11 11 0 0 jtreg:test/nashorn:tier2 36 36 0 0 >> jtreg:test/jaxp:tier2 443 24 419 0 << ============================== ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier3 48 48 0 0 >> jtreg:test/jdk:tier3 2118 2112 6 0 << jtreg:test/langtools:tier3 0 0 0 0 jtreg:test/nashorn:tier3 0 0 0 0 jtreg:test/jaxp:tier3 0 0 0 0 ============================== |
/integrate |
/sponsor |
Going to push as commit 35000fb.
Your commit was automatically rebased without conflicts. |
runtime/appcds/javaldr/GCDuringDump.java can trigger exception occasionally when the default value of
MaxGCPauseMillis
is set to 100ms on jdk11u, so need backport this patch.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2204/head:pull/2204
$ git checkout pull/2204
Update a local copy of the PR:
$ git checkout pull/2204
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2204/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2204
View PR using the GUI difftool:
$ git pr show -t 2204
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2204.diff
Webrev
Link to Webrev Comment