Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region #2204

Closed
wants to merge 1 commit into from

Conversation

sunny868
Copy link
Contributor

@sunny868 sunny868 commented Oct 21, 2023

runtime/appcds/javaldr/GCDuringDump.java can trigger exception occasionally when the default value of MaxGCPauseMillis is set to 100ms on jdk11u, so need backport this patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8213898 needs maintainer approval

Issue

  • JDK-8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2204/head:pull/2204
$ git checkout pull/2204

Update a local copy of the PR:
$ git checkout pull/2204
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2204

View PR using the GUI difftool:
$ git pr show -t 2204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2204.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2023

👋 Welcome back sunny868! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 14b7467279e15fa6fbbfce2d864edbce94a998bc 8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region Oct 21, 2023
@openjdk
Copy link

openjdk bot commented Oct 21, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 21, 2023

⚠️ @sunny868 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2023

Webrevs

@sunny868
Copy link
Contributor Author

/approval request Fix Request 11u

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@sunny868
8213898: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 24, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 24, 2023

Please be a bit more elaborate in you approval request. You should mention reason, risk and testing.

@sunny868
Copy link
Contributor Author

/approval request Fix Request jdk11u
Applies cleanly. no risk. test tier1 passed.

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

@sunny868
8213898: The approval request has been updated successfully.

@GoeLin
Copy link
Member

GoeLin commented Oct 25, 2023

Well, ok... tier1 is a bare minimum of tests, and run by the GHA anyways. GC changes should be tested more intensely, it's a major component of the JVM.

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

⚠️ @sunny868 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8213898
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@sunny868 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region

HeapRegionManager::find_highest_free needs to check if the region obtained from the HeapRegionManager::_regions is available.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 365dacc: 8309095: Remove UTF-8 character from TaskbarPositionTest.java
  • f6a05cf: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out
  • c922821: 8301167: Update VerifySignedJar to actually exercise and test verification
  • a28f66b: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
  • ce38b3e: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • 2835c6a: 8254711: Add java.security.Provider.getService JFR Event
  • 129e856: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • c124213: 8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog
  • fb8676a: 8223788: [macos] JSpinner buttons in JColorChooser dialog may capture focus using TAB Key.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 25, 2023
@sunny868
Copy link
Contributor Author

sunny868 commented Oct 25, 2023

I have already make run-test for tire2-3 for x86_84 locally. I check failed items are not related to this patch.

==============================
Test summary                                                                    
 ==============================
   TEST                                              TOTAL  PASS  FAIL ERROR       
   jtreg:test/hotspot/jtreg:tier2                      325   325     0     0       
>> jtreg:test/jdk:tier2                               3477  3466    10     1 <<  
   jtreg:test/langtools:tier2                           11    11     0     0       
   jtreg:test/nashorn:tier2                             36    36     0     0       
>> jtreg:test/jaxp:tier2                               443    24   419     0 <<  
==============================

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg:tier3                       48    48     0     0   
>> jtreg:test/jdk:tier3                               2118  2112     6     0 <<
   jtreg:test/langtools:tier3                            0     0     0     0   
   jtreg:test/nashorn:tier3                              0     0     0     0   
   jtreg:test/jaxp:tier3                                 0     0     0     0   
==============================

@sunny868
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@sunny868
Your change (at version d236e85) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 27, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 27, 2023

Going to push as commit 35000fb.
Since your change was applied there have been 11 commits pushed to the master branch:

  • a4080b9: 8217329: JTREG: Clean up, remove unused imports in gc folder
  • a6ee5aa: 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly
  • 365dacc: 8309095: Remove UTF-8 character from TaskbarPositionTest.java
  • f6a05cf: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out
  • c922821: 8301167: Update VerifySignedJar to actually exercise and test verification
  • a28f66b: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
  • ce38b3e: 8273804: Platform.isTieredSupported should handle the no-compiler case
  • 2835c6a: 8254711: Add java.security.Provider.getService JFR Event
  • 129e856: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS
  • c124213: 8153090: TAB key cannot change input focus after the radio button in the Color Selection dialog
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/639afbe61ac91ce7f926f01a0f8e63dd694723f5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 27, 2023
@openjdk openjdk bot closed this Oct 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 27, 2023
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 27, 2023

@GoeLin @sunny868 Pushed as commit 35000fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sunny868 sunny868 deleted the JDK-8213898 branch October 27, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants