Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303215: Make thread stacks not use huge pages #2208

Closed
wants to merge 2 commits into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 24, 2023

Backported for parity with Oracle and as preparation to fix https://bugs.openjdk.org/browse/JDK-8312182.

Backport is unclean, but the difference is minor. I had to adjust hunks in os::large_page_init() since the surrounding coding changed a lot since JDK 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8303215 needs maintainer approval

Issue

  • JDK-8303215: Make thread stacks not use huge pages (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2208/head:pull/2208
$ git checkout pull/2208

Update a local copy of the PR:
$ git checkout pull/2208
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2208

View PR using the GUI difftool:
$ git pr show -t 2208

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2208.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 59d9d9fcb93c26dd8931d70934b889245b050acc 8303215: Make thread stacks not use huge pages Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 24, 2023
@tstuefe tstuefe marked this pull request as ready for review October 24, 2023 07:09
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2023

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Oct 24, 2023

@gnu-andrew maybe ?

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the start of os::large_page_init(), there's an extra blank line after the method signature. Otherwise fine.

@tstuefe
Copy link
Member Author

tstuefe commented Nov 14, 2023

At the start of os::large_page_init(), there's an extra blank line after the method signature. Otherwise fine.

Thank you, Paul!

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

⚠️ @tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

@tstuefe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2024

@tstuefe This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants