Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263530: sun.awt.X11.ListHelper.removeAll() should use clear() #2216

Closed

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Oct 24, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8263530 needs maintainer approval

Issue

  • JDK-8263530: sun.awt.X11.ListHelper.removeAll() should use clear() (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2216/head:pull/2216
$ git checkout pull/2216

Update a local copy of the PR:
$ git checkout pull/2216
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2216/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2216

View PR using the GUI difftool:
$ git pr show -t 2216

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2216.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b4aefe9e1e5bcd370de1bf510a1ed97e57a65bb 8263530: sun.awt.X11.ListHelper.removeAll() should use clear() Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 24, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 25, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 26, 2023

Hi @SoniaZaldana
Do you have the possibility to do more elaborate testing than just GH actions?
They are only a sanity check, but not meant as basic test of a change or backport.
Best regards,
Goetz.

@GoeLin
Copy link
Member

GoeLin commented Oct 27, 2023

I ran this through SAP testing.
/approve yes

@openjdk
Copy link

openjdk bot commented Oct 27, 2023

@GoeLin
8263530: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 27, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263530: sun.awt.X11.ListHelper.removeAll() should use clear()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

  • 5a7b227: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
  • 1b6ff86: 8260035: Deproblemlist few problemlisted test
  • 4aa3196: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 5d14b13: 8275333: Print count in "Too many recored phases?" assert
  • 27bfce0: 8210265: Crash in HSpaceCounters::update_used()
  • 2b9d54a: 8306134: Open source some AWT tests relating to Button and a few other classes
  • a2ef248: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • 6038e04: 8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB
  • 623fd8e: 8212997: [TESTBUG] Remove defmeth tests for class file versions 50 and 51
  • 8f7589f: 8211045: [Testbug] Fix for 8144279 didn't define a test case!
  • ... and 53 more: https://git.openjdk.org/jdk11u-dev/compare/c12421376a1d4945b48ab4c6d8dc2e83246d1889...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 27, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@SoniaZaldana
Your change (at version f749125) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Nov 13, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Nov 28, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit be01e6e.
Since your change was applied there have been 83 commits pushed to the master branch:

  • 40ee106: 8282143: Objects.requireNonNull should be ForceInline
  • a3661a5: 8231556: Wrong font ligatures used when 2 versions of same font used
  • f65058e: 8053479: (dc) DatagramChannel.read() throws exception instead of discarding data when buffer too small
  • a956ba6: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 911c359: 8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException
  • bd7420a: 8224035: Replace wildcard address with loopback or local host in tests - part 9
  • f9bedac: 8218178: vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java fails with -Xcomp
  • 345122d: 8067250: [mlvm] vm/mlvm/mixed/stress/regression/b6969574 fails and perf regression
  • 1f4decf: 8318759: Add four DigiCert root certificates
  • 6321d3e: 8316746: Top of lock-stack does not match the unlocked object
  • ... and 73 more: https://git.openjdk.org/jdk11u-dev/compare/c12421376a1d4945b48ab4c6d8dc2e83246d1889...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@jerboaa @SoniaZaldana Pushed as commit be01e6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants