Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314263: Signed jars triggering Logger finder recursion and StackOverflowError #2223

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Oct 27, 2023

I backport this for parity with 11.0.22-oracle.

test/jdk/java/lang/System/LoggerFinder/RecursiveLoading/PlatformRecursiveLoadingTest.java
test/jdk/java/lang/System/LoggerFinder/RecursiveLoading/RecursiveLoadingTest.java
"SimpleLogRecord" is modified due to "Record" is not supported in jdk11

test/jdk/java/lang/System/LoggerFinder/SignedLoggerFinderTest/SignedLoggerFinderTest.java
test/jdk/java/lang/System/LoggerFinder/SignedLoggerFinderTest/SimpleLoggerFinder.java
"long sleep = new Random().nextLong(1000L) + 1L;" is modified due to not supported in jdk11


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8314263 needs maintainer approval
  • JDK-8316087 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315696 needs maintainer approval

Issues

  • JDK-8314263: Signed jars triggering Logger finder recursion and StackOverflowError (Bug - P2 - Approved)
  • JDK-8315696: SignedLoggerFinderTest.java test failed (Bug - P3 - Approved)
  • JDK-8316087: Test SignedLoggerFinderTest.java is still failing (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2223/head:pull/2223
$ git checkout pull/2223

Update a local copy of the PR:
$ git checkout pull/2223
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2223

View PR using the GUI difftool:
$ git pr show -t 2223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2223.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@luchenlin luchenlin changed the title Andrew lu backport 8314263 Backport 7daae1fb4267f92b38f0152611d69b7b89691087 Oct 27, 2023
@openjdk openjdk bot changed the title Backport 7daae1fb4267f92b38f0152611d69b7b89691087 8314263: Signed jars triggering Logger finder recursion and StackOverflowError Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 27, 2023
@luchenlin
Copy link
Contributor Author

/issue add JDK-8315696

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 27, 2023

@luchenlin
Adding additional issue to issue list: 8315696: SignedLoggerFinderTest.java test failed.

@luchenlin
Copy link
Contributor Author

/issue add JDK-8316087

@openjdk
Copy link

openjdk bot commented Oct 27, 2023

@luchenlin
Adding additional issue to issue list: 8316087: Test SignedLoggerFinderTest.java is still failing.

@mlbridge
Copy link

mlbridge bot commented Oct 27, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 30, 2023
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member

GoeLin commented Nov 7, 2023

/approve yes all

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@GoeLin usage: /approve [<id>] (yes|no)

@GoeLin
Copy link
Member

GoeLin commented Nov 7, 2023

/approve all yes

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@GoeLin usage: /approve [<id>] (yes|no)

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8314263: Signed jars triggering Logger finder recursion and StackOverflowError
8315696: SignedLoggerFinderTest.java test failed
8316087: Test SignedLoggerFinderTest.java is still failing

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • 3592b70: 8317373: Add Telia Root CA v2
  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 5754eb1: 8290469: Add new positioning options to PassFailJFrame test framework
  • 2aca53f: 8026393: jarsigner never shows a warning in badKeyUsage case
  • ff19eeb: 8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java
  • 2f3fc25: 8232135: Add diagnostic output to test java/util/ProcessBuilder/Basic.java
  • 48f1f39: 8230435: Replace wildcard address with loopback or local host in tests - part 22
  • b64a1ac: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • ... and 36 more: https://git.openjdk.org/jdk11u-dev/compare/c12421376a1d4945b48ab4c6d8dc2e83246d1889...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 7, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@luchenlin
Your change (at version 0ab362e) is now ready to be sponsored by a Committer.

@RealLucy
Copy link
Contributor

RealLucy commented Nov 9, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

Going to push as commit c54521b.
Since your change was applied there have been 51 commits pushed to the master branch:

  • 416c48e: 8310265: (process) jspawnhelper should not use argv[0]
  • 34cc089: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • b773f56: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
  • 799a7c8: 8292683: Remove BadKeyUsageTest.java from Problem List
  • 0bc8b22: 8230858: Replace wildcard address with loopback or local host in tests - part 23
  • 3592b70: 8317373: Add Telia Root CA v2
  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 5754eb1: 8290469: Add new positioning options to PassFailJFrame test framework
  • ... and 41 more: https://git.openjdk.org/jdk11u-dev/compare/c12421376a1d4945b48ab4c6d8dc2e83246d1889...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2023
@openjdk openjdk bot closed this Nov 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2023
@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@RealLucy @luchenlin Pushed as commit c54521b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants