Skip to content

8284331: Add sanity check for signal handler modification warning. #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Oct 27, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8284331 needs maintainer approval

Issue

  • JDK-8284331: Add sanity check for signal handler modification warning. (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2232/head:pull/2232
$ git checkout pull/2232

Update a local copy of the PR:
$ git checkout pull/2232
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2232

View PR using the GUI difftool:
$ git pr show -t 2232

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2232.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 116763cb5d58a7316b7bada689a0fa34a7250ee7 8284331: Add sanity check for signal handler modification warning. Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 27, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 27, 2023
@GoeLin
Copy link
Member

GoeLin commented Oct 29, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@GoeLin
8284331: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8284331: Add sanity check for signal handler modification warning.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 2fbb4b9: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 910e2c4: 8308910: Allow executeAndLog to accept running process
  • 46ce8cb: 8306765: Some client related jtreg problem list entries are malformed
  • 9f74d26: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
  • 53acd95: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • dd1994e: 8231931: [TESTBUG] serviceability/sa/TestUniverse.java looks for wrong string with Shenandoah
  • cf13e82: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • b9936cd: 8221396: Clean up serviceability/sa/TestUniverse.java
  • 9be4d3f: 8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 29, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@SoniaZaldana
Your change (at version 12df36b) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 6, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

Going to push as commit f993ef5.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 92c5062: 8289238: Refactoring changes to PassFailJFrame Test Framework
  • d90b9ac: 8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
  • 3377127: 8183374: Refactor java/lang/Runtime shell tests to java
  • c73323b: 8240604: Rewrite sun/management/jmxremote/bootstrap/CustomLauncherTest.java test to make binaries from source file
  • 569ecf4: 8226825: Replace wildcard address with loopback or local host in tests - part 19
  • ef475f7: 8224204: Replace wildcard address with loopback or local host in tests - part 10
  • 4ebccd6: 8223145: Replace wildcard address with loopback or local host in tests - part 1
  • d0045da: 8220083: Remove hard-coded 127.0.0.1 loopback address in JDK networking tests
  • de9ae1e: 8293811: Provide a reason for PassFailJFrame.forceFail
  • 32e63eb: 8312065: Socket.connect does not timeout when profiling
  • ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/35000fb1c290e971663969471ddc536e766c0d5e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2023
@openjdk openjdk bot closed this Nov 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@GoeLin @SoniaZaldana Pushed as commit f993ef5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants