8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64

[schmelter-sap]

Hi,

This is a backport of JDK-8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64

Original patch does not apply cleanly to 11u, because the parameters were added
via a List in the original code, but via an array in the JDK 11 code.

Testing: tier1-4 on all platforms with no problems.

Thanks,
-Ralf

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8293166 needs maintainer approval

Issue

• JDK-8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64 (Bug - P3 - Approved)

Reviewers

• Andrew Haley (@theRealAph - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2238/head:pull/2238
$ git checkout pull/2238

Update a local copy of the PR:
$ git checkout pull/2238
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2238

View PR using the GUI difftool:
$ git pr show -t 2238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2238.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (bba8b8a2)

[theRealAph]

This looks OK as far as it goes, but is there a link somewhere to the root cause bug?

[openjdk]

⚠️ @schmelter-sap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[schmelter-sap]

This looks OK as far as it goes, but is there a link somewhere to the root cause bug?

There is no bug report for the 'root cause', since the problem is caused by JFR doing a safepoint during the error handler. This is obviously not safe, but will work most of the time. This change just dramatically decreases the probability that we trigger the bad case in this test.

[tstuefe]

This is a good, minimally invasive patch for a tricky problem.

https://bugs.openjdk.org/browse/JDK-8293166?focusedCommentId=14528737&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14528737 lists the details. There is no easy fix - the secondary signal handler behaves as it should (putting the faulting thread to sleep) in order to minimize disturbances in the future core file.

[openjdk]

@schmelter-sap This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64

Reviewed-by: aph, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• de9ae1e: 8293811: Provide a reason for PassFailJFrame.forceFail
• 32e63eb: 8312065: Socket.connect does not timeout when profiling
• 2fbb4b9: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
• 910e2c4: 8308910: Allow executeAndLog to accept running process
• 46ce8cb: 8306765: Some client related jtreg problem list entries are malformed
• 9f74d26: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
• 53acd95: 8251177: [macosx] The text "big" is truncated in JTabbedPane
• dd1994e: 8231931: [TESTBUG] serviceability/sa/TestUniverse.java looks for wrong string with Shenandoah
• cf13e82: 8313691: use close after failing os::fdopen in vmError and ciEnv
• b9936cd: 8221396: Clean up serviceability/sa/TestUniverse.java
• ... and 13 more: https://git.openjdk.org/jdk11u-dev/compare/639afbe61ac91ce7f926f01a0f8e63dd694723f5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[schmelter-sap]

/integrate

[openjdk]

Going to push as commit b64a1ac.
Since your change was applied there have been 38 commits pushed to the master branch:

• 80d3bb4: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
• 1f67ffb: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
• f6bdbe8: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
• feb051f: 8316906: Clarify TLABWasteTargetPercent flag
• 9abfdde: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
• 18d616d: 8306280: Open source several choice AWT tests
• f993ef5: 8284331: Add sanity check for signal handler modification warning.
• 92c5062: 8289238: Refactoring changes to PassFailJFrame Test Framework
• d90b9ac: 8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
• 3377127: 8183374: Refactor java/lang/Runtime shell tests to java
• ... and 28 more: https://git.openjdk.org/jdk11u-dev/compare/639afbe61ac91ce7f926f01a0f8e63dd694723f5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@schmelter-sap Pushed as commit b64a1ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.