Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293811: Provide a reason for PassFailJFrame.forceFail #2241

Closed

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Oct 30, 2023

Hi all,

This contains a backport of 64b96e5cf57023a5d55b4392074e3922ac7c0534.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8293811 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293811: Provide a reason for PassFailJFrame.forceFail (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2241/head:pull/2241
$ git checkout pull/2241

Update a local copy of the PR:
$ git checkout pull/2241
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2241/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2241

View PR using the GUI difftool:
$ git pr show -t 2241

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2241.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 64b96e5cf57023a5d55b4392074e3922ac7c0534 8293811: Provide a reason for PassFailJFrame.forceFail Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 30, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 30, 2023
@GoeLin
Copy link
Member

GoeLin commented Nov 1, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@GoeLin
8293811: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8293811: Provide a reason for PassFailJFrame.forceFail

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 32e63eb: 8312065: Socket.connect does not timeout when profiling

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@SoniaZaldana
Your change (at version 4f87b16) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit de9ae1e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 32e63eb: 8312065: Socket.connect does not timeout when profiling

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@phohensee @SoniaZaldana Pushed as commit de9ae1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants