-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8289511: Improve test coverage for XPath Axes: child #2243
Conversation
👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Hi @SoniaZaldana, please first get a review, then request approval. I eventually will remove the label to get it out of my worklist if it is not ready for approval. You can label again once it fulfils all requirements. |
@SoniaZaldana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks clean, other than the need to replace the use of JEP 355 Text Blocks. The replacement version looks good, though I can see why they wanted to use text blocks for this and avoid all the additional escaping.
I presume the test passes on 11u?
/approve yes |
@GoeLin |
@SoniaZaldana This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 70 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@SoniaZaldana |
Thanks @gnu-andrew! Yes, the test passes on 11u. |
/sponsor |
Going to push as commit ac1764d.
Your commit was automatically rebased without conflicts. |
@tstuefe @SoniaZaldana Pushed as commit ac1764d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This backport contains cfe9026fe0506488cc0f0557299cfa585811d194.
Patch does not apply cleanly. Notably, I made a change in how the string XML is initialized.
Original commit uses triple quotes which are not yet enabled in jdk 11. I am adding the relevant differences below.
Test passes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2243/head:pull/2243
$ git checkout pull/2243
Update a local copy of the PR:
$ git checkout pull/2243
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2243/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2243
View PR using the GUI difftool:
$ git pr show -t 2243
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2243.diff
Webrev
Link to Webrev Comment