Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223145: Replace wildcard address with loopback or local host in tests - part 1 #2245

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 31, 2023

I backport this for parity with 11.0.21-oracle.

Omitted changes to TestHttpServer.java, URIBuilder.java. They are already in 11.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8223145 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8223145: Replace wildcard address with loopback or local host in tests - part 1 (Sub-task - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2245/head:pull/2245
$ git checkout pull/2245

Update a local copy of the PR:
$ git checkout pull/2245
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2245

View PR using the GUI difftool:
$ git pr show -t 2245

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2245.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2222 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7d4520c109f408a7dbcdcc424dfef121e3eeaaa7 8223145: Replace wildcard address with loopback or local host in tests - part 1 Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 31, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 31, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added approval and removed approval labels Nov 2, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Nov 6, 2023

/integrate

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/2222 to master November 6, 2023 07:31
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8223145
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223145: Replace wildcard address with loopback or local host in tests - part 1

Replaces binding to wildacard with alternative less susceptible to intermittent failure in some intermittently failing tests.

Reviewed-by: mbaesken, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • d0045da: 8220083: Remove hard-coded 127.0.0.1 loopback address in JDK networking tests
  • de9ae1e: 8293811: Provide a reason for PassFailJFrame.forceFail
  • 32e63eb: 8312065: Socket.connect does not timeout when profiling
  • 2fbb4b9: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 910e2c4: 8308910: Allow executeAndLog to accept running process
  • 46ce8cb: 8306765: Some client related jtreg problem list entries are malformed
  • 9f74d26: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
  • 53acd95: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • dd1994e: 8231931: [TESTBUG] serviceability/sa/TestUniverse.java looks for wrong string with Shenandoah
  • cf13e82: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/a6ee5aa738d9312b28cf8940786fd7d1da381cef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

Going to push as commit 4ebccd6.
Since your change was applied there have been 14 commits pushed to the master branch:

  • d0045da: 8220083: Remove hard-coded 127.0.0.1 loopback address in JDK networking tests
  • de9ae1e: 8293811: Provide a reason for PassFailJFrame.forceFail
  • 32e63eb: 8312065: Socket.connect does not timeout when profiling
  • 2fbb4b9: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 910e2c4: 8308910: Allow executeAndLog to accept running process
  • 46ce8cb: 8306765: Some client related jtreg problem list entries are malformed
  • 9f74d26: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
  • 53acd95: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • dd1994e: 8231931: [TESTBUG] serviceability/sa/TestUniverse.java looks for wrong string with Shenandoah
  • cf13e82: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/a6ee5aa738d9312b28cf8940786fd7d1da381cef...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2023
@openjdk openjdk bot closed this Nov 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@GoeLin Pushed as commit 4ebccd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8223145 branch November 6, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants