Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8224204: Replace wildcard address with loopback or local host in tests - part 10 #2248

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 31, 2023

I backport this to simplify later backports.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8224204 needs maintainer approval

Issue

  • JDK-8224204: Replace wildcard address with loopback or local host in tests - part 10 (Sub-task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2248/head:pull/2248
$ git checkout pull/2248

Update a local copy of the PR:
$ git checkout pull/2248
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2248

View PR using the GUI difftool:
$ git pr show -t 2248

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2248.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a974268f17f5059021680fec7af9dc83409a6daa 8224204: Replace wildcard address with loopback or local host in tests - part 10 Oct 31, 2023
@openjdk
Copy link

openjdk bot commented Oct 31, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 31, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8224204: Replace wildcard address with loopback or local host in tests - part 10

Fixed intermittently failing tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • de9ae1e: 8293811: Provide a reason for PassFailJFrame.forceFail

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 2, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Nov 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

Going to push as commit ef475f7.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 4ebccd6: 8223145: Replace wildcard address with loopback or local host in tests - part 1
  • d0045da: 8220083: Remove hard-coded 127.0.0.1 loopback address in JDK networking tests
  • de9ae1e: 8293811: Provide a reason for PassFailJFrame.forceFail

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2023
@openjdk openjdk bot closed this Nov 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@GoeLin Pushed as commit ef475f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant