8242882: opening jar file with large manifest might throw NegativeArraySizeException

[shipilev]

Unclean backport to match 11.0.13-oracle. The uncleanliness is due to ambuity in JarUtils.createJarFile that does not have the overload with just (Path, Path), as it was added in later JDKs. I added the Paths.get(".") to do the same thing.

        JarUtils.createJarFile(jarFilePath.toAbsolutePath(), jarSourceRoot, Paths.get("."));

Additional testing:

• New test fails without the patch
• New test passes with the patch

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8242882: opening jar file with large manifest might throw NegativeArraySizeException

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/225/head:pull/225
$ git checkout pull/225

Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 225

View PR using the GUI difftool:
$ git pr show -t 225

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/225.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e92757da)

[phohensee]

Lgtm.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242882: opening jar file with large manifest might throw NegativeArraySizeException

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• bdfc60a: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Got the push approval.

/integrate

[openjdk]

Going to push as commit 7b6f391.
Since your change was applied there have been 19 commits pushed to the master branch:

• dffc5f4: 8211092: test/jdk/sun/net/www/http/HttpClient/MultiThreadTest.java fails intermittently when cleaning up
• 236a469: 8214937: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed due to unexpected expiration date
• 868921f: 8235216: typo in test filename
• 177d177: 8246261: TCKLocalTime.java failed due to "AssertionError: expected [18:14:22] but found [18:14:23]"
• 93b826b: 8213235: java/nio/channels/SocketChannel/AsyncCloseChannel.java fails with threads that didn't exit
• ec71e34: 8216532: tools/launcher/Test7029048.java fails (Solaris)
• 8434e33: 8210934: Move sun/net/www/protocol/http/GetErrorStream.java to OpenJDK
• 270786f: 8210669: Some launcher tests assume a pre-JDK 9 run-time image layout
• 8e63ecb: 8258703: Incorrect 512-bit vector registers restore on x86_32
• d24982f: 8236413: AbstractConnectTimeout should tolerate both NoRouteToHostException and UnresolvedAddressException
• ... and 9 more: https://git.openjdk.java.net/jdk11u-dev/compare/5f9429b58f68a2d71b3dae96e15353b780c745a3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 7b6f391.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.