Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB #2257

Closed
wants to merge 3 commits into from

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Nov 6, 2023

Hi all,

This pull request contains a backport of a5343fa60505764c088dad4a17680d92568509d5.

Testing: affected test, tier 1.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8281149 needs maintainer approval

Issue

  • JDK-8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2257/head:pull/2257
$ git checkout pull/2257

Update a local copy of the PR:
$ git checkout pull/2257
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2257

View PR using the GUI difftool:
$ git pr show -t 2257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2257.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a5343fa60505764c088dad4a17680d92568509d5 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 6, 2023
@SoniaZaldana SoniaZaldana marked this pull request as draft November 6, 2023 17:21
@openjdk openjdk bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@SoniaZaldana this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout my-backport-8281149
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Nov 13, 2023
@SoniaZaldana SoniaZaldana marked this pull request as ready for review November 15, 2023 15:37
@openjdk openjdk bot added the clean label Nov 15, 2023
@openjdk
Copy link

openjdk bot commented Nov 15, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review and removed merge-conflict Pull request has merge conflict with target branch labels Nov 15, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8281149: (fs) java/nio/file/FileStore/Basic.java  fails with java.lang.RuntimeException: values differ by more than 1GB

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • 3b2d165: 8186610: move ModuleUtils to top-level testlibrary
  • 1080258: 8218754: JDK-8068225 regression in JDIBreakpointTest
  • 04d2033: 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java
  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java
  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • ... and 19 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 6, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@SoniaZaldana
Your change (at version 5807418) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

Going to push as commit db1d944.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • 3b2d165: 8186610: move ModuleUtils to top-level testlibrary
  • 1080258: 8218754: JDK-8068225 regression in JDIBreakpointTest
  • 04d2033: 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java
  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java
  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • ... and 19 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023
@openjdk openjdk bot closed this Dec 6, 2023
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 6, 2023
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@phohensee @SoniaZaldana Pushed as commit db1d944.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants