8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB

[SoniaZaldana]

Hi all,

This pull request contains a backport of commit e291a67e from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 1 Jul 2022 and was reviewed by Alan Bateman.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8289584 needs maintainer approval

Issue

• JDK-8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2258/head:pull/2258
$ git checkout pull/2258

Update a local copy of the PR:
$ git checkout pull/2258
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2258

View PR using the GUI difftool:
$ git pr show -t 2258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2258.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (baf9aeed)

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8289584: The approval request has been approved.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 34cc089: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
• b773f56: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
• 799a7c8: 8292683: Remove BadKeyUsageTest.java from Problem List
• 0bc8b22: 8230858: Replace wildcard address with loopback or local host in tests - part 23
• 3592b70: 8317373: Add Telia Root CA v2
• 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently
• 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
• 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
• 5754eb1: 8290469: Add new positioning options to PassFailJFrame test framework
• 2aca53f: 8026393: jarsigner never shows a warning in badKeyUsage case
• ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/b64a1acb212a64629094bf7e992d98500f91d629...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version baf9aee) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit 6038e04.
Since your change was applied there have been 18 commits pushed to the master branch:

• 623fd8e: 8212997: [TESTBUG] Remove defmeth tests for class file versions 50 and 51
• 8f7589f: 8211045: [Testbug] Fix for 8144279 didn't define a test case!
• 2bbab16: 8185531: [TESTBUG] Improve test configuration for shared strings
• c54521b: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
• 416c48e: 8310265: (process) jspawnhelper should not use argv[0]
• 34cc089: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
• b773f56: 6445283: ProgressMonitorInputStream not large file aware (>2GB)
• 799a7c8: 8292683: Remove BadKeyUsageTest.java from Problem List
• 0bc8b22: 8230858: Replace wildcard address with loopback or local host in tests - part 23
• 3592b70: 8317373: Add Telia Root CA v2
• ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/b64a1acb212a64629094bf7e992d98500f91d629...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @SoniaZaldana Pushed as commit 6038e04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.