Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317373: Add Telia Root CA v2 #2262

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Nov 6, 2023

Please review this backport, which doesn't apply clean due to missing pattern matching for switch in JDK 11 and some minor context differences. I've resolved them manually.

Testing:

  • GHA
  • jtreg tests: test/jdk/sun/security/lib/cacerts test/jdk/security/infra/java/security/cert/CertPathValidator. The latter includes the new test which passes.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317373 needs maintainer approval

Issue

  • JDK-8317373: Add Telia Root CA v2 (Enhancement - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2262/head:pull/2262
$ git checkout pull/2262

Update a local copy of the PR:
$ git checkout pull/2262
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2262/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2262

View PR using the GUI difftool:
$ git pr show -t 2262

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2262.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2023

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 37c40a11a78f8b1f290cb04ce5b087904651907e 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 6, 2023
@jerboaa jerboaa changed the title 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267 Nov 6, 2023
@openjdk openjdk bot changed the title Backport d3ebb4a155be8ed93e79b6b58c645e861ec30267 8317373: Add Telia Root CA v2 Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8317373: Add Telia Root CA v2

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 5754eb1: 8290469: Add new positioning options to PassFailJFrame test framework
  • 2aca53f: 8026393: jarsigner never shows a warning in badKeyUsage case
  • ff19eeb: 8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java
  • 2f3fc25: 8232135: Add diagnostic output to test java/util/ProcessBuilder/Basic.java
  • 48f1f39: 8230435: Replace wildcard address with loopback or local host in tests - part 22
  • b64a1ac: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 80d3bb4: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • ... and 16 more: https://git.openjdk.org/jdk11u-dev/compare/2fbb4b92bdcbc3a478c06cc6c904391c1d2e326e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 7, 2023
@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

Going to push as commit 3592b70.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 662f3bd: 8317920: JDWP-agent sends broken exception event with onthrow option
  • 68807aa: 8314242: Update applications/scimark/Scimark.java to accept VM flags
  • 5754eb1: 8290469: Add new positioning options to PassFailJFrame test framework
  • 2aca53f: 8026393: jarsigner never shows a warning in badKeyUsage case
  • ff19eeb: 8285687: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java
  • 2f3fc25: 8232135: Add diagnostic output to test java/util/ProcessBuilder/Basic.java
  • 48f1f39: 8230435: Replace wildcard address with loopback or local host in tests - part 22
  • b64a1ac: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
  • 80d3bb4: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
  • ... and 16 more: https://git.openjdk.org/jdk11u-dev/compare/2fbb4b92bdcbc3a478c06cc6c904391c1d2e326e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 7, 2023
@openjdk openjdk bot closed this Nov 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

@jerboaa Pushed as commit 3592b70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants