Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275333: Print count in "Too many recored phases?" assert #2264

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 7, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8275333 needs maintainer approval

Issue

  • JDK-8275333: Print count in "Too many recored phases?" assert (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2264/head:pull/2264
$ git checkout pull/2264

Update a local copy of the PR:
$ git checkout pull/2264
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2264

View PR using the GUI difftool:
$ git pr show -t 2264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2264.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 45ebf85ca9a1e071955ba2e3cb32449bfbd85d14 8275333: Print count in "Too many recored phases?" assert Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 7, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2023

Webrevs

@luchenlin luchenlin closed this Nov 10, 2023
@luchenlin luchenlin reopened this Nov 10, 2023
@openjdk openjdk bot added the approval label Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275333: Print count in "Too many recored phases?" assert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 27bfce0: 8210265: Crash in HSpaceCounters::update_used()
  • 2b9d54a: 8306134: Open source some AWT tests relating to Button and a few other classes
  • a2ef248: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • 6038e04: 8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB
  • 623fd8e: 8212997: [TESTBUG] Remove defmeth tests for class file versions 50 and 51
  • 8f7589f: 8211045: [Testbug] Fix for 8144279 didn't define a test case!
  • 2bbab16: 8185531: [TESTBUG] Improve test configuration for shared strings
  • c54521b: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
  • 416c48e: 8310265: (process) jspawnhelper should not use argv[0]
  • 34cc089: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/b64a1acb212a64629094bf7e992d98500f91d629...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 13, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@luchenlin
Your change (at version 2c2a16b) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 13, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

Going to push as commit 5d14b13.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 27bfce0: 8210265: Crash in HSpaceCounters::update_used()
  • 2b9d54a: 8306134: Open source some AWT tests relating to Button and a few other classes
  • a2ef248: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • 6038e04: 8289584: (fs) Print size values in java/nio/file/FileStore/Basic.java when they differ by > 1GiB
  • 623fd8e: 8212997: [TESTBUG] Remove defmeth tests for class file versions 50 and 51
  • 8f7589f: 8211045: [Testbug] Fix for 8144279 didn't define a test case!
  • 2bbab16: 8185531: [TESTBUG] Improve test configuration for shared strings
  • c54521b: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
  • 416c48e: 8310265: (process) jspawnhelper should not use argv[0]
  • 34cc089: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/b64a1acb212a64629094bf7e992d98500f91d629...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 13, 2023
@openjdk openjdk bot closed this Nov 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@GoeLin @luchenlin Pushed as commit 5d14b13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants