Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? #2266

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 7, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8275329 needs maintainer approval
  • JDK-8275333 needs maintainer approval

Issues

  • JDK-8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? (Bug - P2)
  • JDK-8275333: Print count in "Too many recored phases?" assert (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2266/head:pull/2266
$ git checkout pull/2266

Update a local copy of the PR:
$ git checkout pull/2266
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2266

View PR using the GUI difftool:
$ git pr show -t 2266

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2266.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b833db3f9cace8fbb09bb803ba31208e37a4622 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 7, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 10, 2023

@luchenlin
Adding additional issue to issue list: 8275333: Print count in "Too many recored phases?" assert.

@luchenlin luchenlin closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant