Skip to content

8230858: Replace wildcard address with loopback or local host in tests - part 23 #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 7, 2023

I backport this for parity with 11.0.21-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8230858 needs maintainer approval

Issue

  • JDK-8230858: Replace wildcard address with loopback or local host in tests - part 23 (Sub-task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2269/head:pull/2269
$ git checkout pull/2269

Update a local copy of the PR:
$ git checkout pull/2269
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2269

View PR using the GUI difftool:
$ git pr show -t 2269

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2269.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e9eaba3d538fcd2d8b5642f227433d69faef2552 8230858: Replace wildcard address with loopback or local host in tests - part 23 Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 7, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 7, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2023

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 7, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8230858: Replace wildcard address with loopback or local host in tests - part 23

Add new traces for better diagnosis, refrain binding to the wildcard address when possible.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3592b70: 8317373: Add Telia Root CA v2
  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 8, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Nov 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

Going to push as commit 0bc8b22.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 3592b70: 8317373: Add Telia Root CA v2
  • 75daf18: 8315214: Do not run sun/tools/jhsdb tests concurrently

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2023
@openjdk openjdk bot closed this Nov 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@GoeLin Pushed as commit 0bc8b22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant