8225377: type annotations are not visible to javac plugins across compilation boundaries

[cushon]

Hi,

This is a backport of JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries

The patch did not apply cleanly. I resolved a merge conflict with the imports, and due to changes to the internal TypeMetadata API for JDK-8303820.

The modified test fails without the patch, and passes with it. The patch passes langtools:tier1 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8225377 needs maintainer approval

Issue

• JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2272/head:pull/2272
$ git checkout pull/2272

Update a local copy of the PR:
$ git checkout pull/2272
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2272

View PR using the GUI difftool:
$ git pr show -t 2272

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2272.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (ec63a752)
• 00: Full (747dad7d)

[bridgekeeper]

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[cushon]

Please keep this one open

[openjdk]

⚠️ @cushon This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@cushon This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8225377: type annotations are not visible to javac plugins across compilation boundaries

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• aa03b6f: 8211438: [Testbug] runtime/XCheckJniJsig/XCheckJSig.java looks for libjsig in wrong location
• 3a961da: 8209946: [TESTBUG] CDS tests should use "@run driver"
• dec947a: 8209549: remove VMPropsExt from TEST.ROOT
• 1adabcd: 8307683: Loop Predication should not hoist range checks with trap on success projection by negating their condition

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[cushon]

I'm holding off on merging this until the follow-up in #2312 is also ready to merge, it is waiting on maintainer approval

[cushon]

/integrate

[openjdk]

@cushon
Your change (at version ec63a75) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit bd5ef73.
Since your change was applied there have been 21 commits pushed to the master branch:

• f06fe1c: 8318951: Additional negative value check in JPEG decoding
• 0107cb2: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
• 5243535: 8306996: Open source Swing MenuItem related tests
• da4bfa7: 8307130: Open source few Swing JMenu tests
• 57abf97: 8305505: NPE in javazic compiler
• 1ed87b6: 8306072: Open source several AWT MouseInfo related tests
• 50a1dc7: 8302149: Speed up compiler/jsr292/methodHandleExceptions/TestAMEnotNPE.java
• f572042: 8296384: [TESTBUG] sun/security/provider/SecureRandom/AbstractDrbg/SpecTest.java intermittently timeout
• 8f5b522: 8293819: sun/util/logging/PlatformLoggerTest.java failed with "RuntimeException: Retrieved backing PlatformLogger level null is not the expected CONFIG"
• 6dd9ab1: 8285785: CheckCleanerBound test fails with PasswordCallback object is not released
• ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/b3d7b57a73a82e6df01f6486e614990ac9589d65...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @cushon Pushed as commit bd5ef73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.