Skip to content

8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 10, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8275329 needs maintainer approval

Issue

  • JDK-8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2275/head:pull/2275
$ git checkout pull/2275

Update a local copy of the PR:
$ git checkout pull/2275
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2275

View PR using the GUI difftool:
$ git pr show -t 2275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2275.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b833db3f9cace8fbb09bb803ba31208e37a4622 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases? Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 10, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2023

Webrevs

GoeLin and others added 23 commits November 13, 2023 17:21
…s - part 22

Fixes tests to use the loopback address whenever possible. It also fixes some safe publishing issues, or add diagnostics in some of the tests.

Reviewed-by: lucy
Backport-of: f71db30
…PageRangesDlgTest.java

Reviewed-by: lucy
Backport-of: fc3edf2412461f41ac4dfd8b047257432620ba6d
Backport-of: 62140e249cf78d8d4acd1e5ab76bac0cc013a1a5
Backport-of: 6bf4a33593bfe0df9b5ba81de5321a04f4dbe0ea
Reviewed-by: clanger
Backport-of: 1e7e2bcf3560e1ad39516fb604e4d8bf85bb54e0
Reviewed-by: phh
Backport-of: d3ebb4a155be8ed93e79b6b58c645e861ec30267
…s - part 23

Add new traces for better diagnosis, refrain binding to the wildcard address when possible.

Backport-of: e9eaba3
Backport-of: df5209e70fd92ec6bda4e7356a3ad121732f6c66
Backport-of: a17fce7507c7d485d51f98fadd444235ea31058d
….java" fails because the frames of instruction does not display

Backport-of: d1026720d323d0acd9bd8d85d5caba7185107863
Backport-of: cd6cb730c934d8e16d4bd8e3342e59e806f158f9
…flowError

8315696: SignedLoggerFinderTest.java test failed
8316087: Test SignedLoggerFinderTest.java is still failing

Reviewed-by: lucy
Backport-of: 7daae1fb4267f92b38f0152611d69b7b89691087
Added extra test configurations to the tests

Backport-of: 8a5467b
Add missing file from original commit

Backport-of: bc6fb26
…d 51

Remove the unneeded tests.  Keep the tests for class file versions 49 and 52.

Backport-of: 71637b0
… when they differ by > 1GiB

Backport-of: e291a67e96970d80a9915f8a23afffed6e0b8ded
…le static imports

Backport-of: f79b3d42f07b703f0e3b9fc67c92dee260b0e602
…r classes

Backport-of: fdb4bafa3142cedeb9eb3cb930890e97b35402de
# Conflicts:
#	src/hotspot/share/gc/shared/gcTimer.cpp
#	test/hotspot/jtreg/gc/TestNoPerfCounter.java
@openjdk openjdk bot added the clean label Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 16, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

@luchenlin
Your change (at version 902ad6d) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 20, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

Going to push as commit 10ddd51.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • 046b213: 8268916: Tests for AffirmTrust roots

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2023
@openjdk openjdk bot closed this Nov 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

@GoeLin @luchenlin Pushed as commit 10ddd51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

6 participants