Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows #2276

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 10, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8265678 needs maintainer approval
  • JDK-8168408 needs maintainer approval

Issues

  • JDK-8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows (Bug - P4 - Approved)
  • JDK-8265678: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2276/head:pull/2276
$ git checkout pull/2276

Update a local copy of the PR:
$ git checkout pull/2276
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2276/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2276

View PR using the GUI difftool:
$ git pr show -t 2276

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2276.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 45c474a04c61e65c9a8a305598ea9b34a0513fa7 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Nov 10, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/issue 8265678

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@luchenlin
Adding additional issue to issue list: 8265678: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows.

@openjdk openjdk bot added the approval label Nov 13, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot removed the approval label Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@luchenlin This pull request has not yet been marked as ready for integration.

@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@luchenlin This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
8265678: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 27bfce0: 8210265: Crash in HSpaceCounters::update_used()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 13, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@luchenlin
Your change (at version 9c2c268) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 13, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 13, 2023

Going to push as commit 5a7b227.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 1b6ff86: 8260035: Deproblemlist few problemlisted test
  • 4aa3196: 8258914: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 5d14b13: 8275333: Print count in "Too many recored phases?" assert
  • 27bfce0: 8210265: Crash in HSpaceCounters::update_used()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 13, 2023
@openjdk openjdk bot closed this Nov 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 13, 2023
@openjdk
Copy link

openjdk bot commented Nov 13, 2023

@GoeLin @luchenlin Pushed as commit 5a7b227.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants