Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException #2285

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 21, 2023

I backport this for parity with 11.0.22-oracle.
Also backport for JDK-8232513. Clean backports.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8232513 needs maintainer approval
  • Change must not contain extraneous whitespace
  • JDK-8249812 needs maintainer approval
  • Commit message must refer to an issue

Issues

  • JDK-8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException (Bug - P4 - Approved)
  • JDK-8232513: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with BindException (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2285/head:pull/2285
$ git checkout pull/2285

Update a local copy of the PR:
$ git checkout pull/2285
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2285/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2285

View PR using the GUI difftool:
$ git pr show -t 2285

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2285.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9f23c2c159fdb992edc4023f9dc5e9e88b15e53e 8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 21, 2023
@luchenlin
Copy link
Contributor Author

/issue add JDK-8232513

@mlbridge
Copy link

mlbridge bot commented Nov 21, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@luchenlin
Adding additional issue to issue list: 8232513: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with BindException.

@openjdk openjdk bot added approval and removed approval labels Nov 22, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@luchenlin This pull request has not yet been marked as ready for integration.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify the test runs successfully?

@luchenlin
Copy link
Contributor Author

Did you verify the test runs successfully?

yes, local test pass.

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
Once nightly tests have passed feel free to integrate.

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException
8232513: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with BindException

Fixed the test to reenable its retry logic

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 2420592: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • a72d0b2: 8240754: Instrument FlowTest.java to provide more debug traces.
  • fca62cf: 8289077: Add manual tests to open
  • 250d7a8: 8214694: cleanup rawtypes warnings in open jndi tests
  • fac5955: 8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol
  • f2488a3: 8317374: Add Let's Encrypt ISRG Root X2
  • 7814102: 8244508: JFR: FlightRecorderOptions reset date format
  • 10ddd51: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 45e3cbf: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 25, 2023
@openjdk
Copy link

openjdk bot commented Nov 25, 2023

@luchenlin
Your change (at version 7099941) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 28, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit 911c359.
Since your change was applied there have been 14 commits pushed to the master branch:

  • bd7420a: 8224035: Replace wildcard address with loopback or local host in tests - part 9
  • f9bedac: 8218178: vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java fails with -Xcomp
  • 345122d: 8067250: [mlvm] vm/mlvm/mixed/stress/regression/b6969574 fails and perf regression
  • 1f4decf: 8318759: Add four DigiCert root certificates
  • 6321d3e: 8316746: Top of lock-stack does not match the unlocked object
  • 2420592: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • a72d0b2: 8240754: Instrument FlowTest.java to provide more debug traces.
  • fca62cf: 8289077: Add manual tests to open
  • 250d7a8: 8214694: cleanup rawtypes warnings in open jndi tests
  • fac5955: 8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/046b213712ea32b17a289c546c9719a99bb2ff6c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@GoeLin @luchenlin Pushed as commit 911c359.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants