-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316746: Top of lock-stack does not match the unlocked object #2288
8316746: Top of lock-stack does not match the unlocked object #2288
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Cheers, Richard.
|
Thanks for the review! |
/approval request C2 OSR compiled methods are wrong on PPC64 in very rare cases without this fix (wrong unlock order). This gets currently only detected by the new lightweight locking, but the bug exists independently. The fix has been tested in jdk head, jdk 21u and the backport in jdk 17u-dev and jdk 11u-dev in our nightly tests. The version for 11 is almost identical to the version for 17 and has been reviewed. |
@TheRealMDoerr |
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 6321d3e.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 6321d3e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8316746. Version from 17u-dev is almost identical. Diffs:
_abi
has been renamed to_abi0
in later JDK versions.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2288/head:pull/2288
$ git checkout pull/2288
Update a local copy of the PR:
$ git checkout pull/2288
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2288/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2288
View PR using the GUI difftool:
$ git pr show -t 2288
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2288.diff
Webrev
Link to Webrev Comment