Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318759: Add four DigiCert root certificates #2289

Closed
wants to merge 4 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Nov 22, 2023

I backport this for parity with 11.0.22-oracle.
location of the certs and the hash in the test changed, follow the jdk17 backport


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8318759 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8318759: Add four DigiCert root certificates (Enhancement - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2289/head:pull/2289
$ git checkout pull/2289

Update a local copy of the PR:
$ git checkout pull/2289
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2289/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2289

View PR using the GUI difftool:
$ git pr show -t 2289

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2289.diff

Webrev

Link to Webrev Comment

i556354 added 3 commits November 21, 2023 17:02
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0ea58048f9b4cdaaa0470b2bcc03913fb3939453 8318759: Add four DigiCert root certificates Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 22, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8318759: Add four DigiCert root certificates

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • a72d0b2: 8240754: Instrument FlowTest.java to provide more debug traces.
  • fca62cf: 8289077: Add manual tests to open
  • 250d7a8: 8214694: cleanup rawtypes warnings in open jndi tests
  • fac5955: 8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 23, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 24, 2023
@openjdk
Copy link

openjdk bot commented Nov 24, 2023

@luchenlin
Your change (at version 935b178) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Nov 28, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit 1f4decf.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 6321d3e: 8316746: Top of lock-stack does not match the unlocked object
  • 2420592: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • a72d0b2: 8240754: Instrument FlowTest.java to provide more debug traces.
  • fca62cf: 8289077: Add manual tests to open
  • 250d7a8: 8214694: cleanup rawtypes warnings in open jndi tests
  • fac5955: 8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@jerboaa @luchenlin Pushed as commit 1f4decf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants