8053479: (dc) DatagramChannel.read() throws exception instead of discarding data when buffer too small

[tabjy]

A clean backport of JDK-8053479

This is a Windows-only issue. The corresponding test is NOT part of tier1 that's automatically verified by GHA. The following shows the test

• fails without the patch: https://github.com/tabjy/jdk11u-ci/actions/runs/6946796354/job/18900472321
• passes with the patch: https://github.com/tabjy/jdk11u-ci/actions/runs/6946228725/job/18903238261

One can verify locally with make run-test-prebuilt TEST='test/jdk/java/nio/channels/DatagramChannel/Truncate.java' ...

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8053479 needs maintainer approval

Issue

• JDK-8053479: (dc) DatagramChannel.read() throws exception instead of discarding data when buffer too small (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2291/head:pull/2291
$ git checkout pull/2291

Update a local copy of the PR:
$ git checkout pull/2291
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2291

View PR using the GUI difftool:
$ git pr show -t 2291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2291.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kxu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @tabjy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (944a46f8)

[tabjy]

/approval request Fix Request jdk11u
Applies cleanly. Issue reproducible and patched for Windows. GHA passes all tier 1 tests; the newly backported unit test passes.

[openjdk]

@tabjy
8053479: The approval request has been created successfully.

[openjdk]

@tabjy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8053479: (dc) DatagramChannel.read() throws exception instead of discarding data when buffer too small

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• a72d0b2: 8240754: Instrument FlowTest.java to provide more debug traces.
• fca62cf: 8289077: Add manual tests to open
• 250d7a8: 8214694: cleanup rawtypes warnings in open jndi tests
• fac5955: 8238740: java/net/httpclient/whitebox/FlowTestDriver.java should not specify a TLS protocol
• f2488a3: 8317374: Add Let's Encrypt ISRG Root X2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[tabjy]

/integrate

[openjdk]

@tabjy
Your change (at version 944a46f) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit f65058e.
Since your change was applied there have been 13 commits pushed to the master branch:

• a956ba6: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
• 911c359: 8249812: java/net/DatagramSocket/PortUnreachable.java still fails intermittently with SocketTimeoutException
• bd7420a: 8224035: Replace wildcard address with loopback or local host in tests - part 9
• f9bedac: 8218178: vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java fails with -Xcomp
• 345122d: 8067250: [mlvm] vm/mlvm/mixed/stress/regression/b6969574 fails and perf regression
• 1f4decf: 8318759: Add four DigiCert root certificates
• 6321d3e: 8316746: Top of lock-stack does not match the unlocked object
• 2420592: 8312126: NullPointerException in CertStore.getCRLs after 8297955
• a72d0b2: 8240754: Instrument FlowTest.java to provide more debug traces.
• fca62cf: 8289077: Add manual tests to open
• ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/78141024c23efab479b9e3cac851198299166155...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @tabjy Pushed as commit f65058e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.