Skip to content

8208699: remove unneeded imports from runtime tests #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Nov 29, 2023

Backport of JDK-8208699


Progress

  • Change must not contain extraneous whitespace
  • JDK-8208699 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8208699: remove unneeded imports from runtime tests (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2303/head:pull/2303
$ git checkout pull/2303

Update a local copy of the PR:
$ git checkout pull/2303
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2303

View PR using the GUI difftool:
$ git pr show -t 2303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2303.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 940ac1cddc3317ced9a5c9b6b0f1c85b8fd6cdaf 8208699: remove unneeded imports from runtime tests Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Nov 30, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Clean backort. SAP nightlies passed on 2023-11-30.”

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@amosshi
8208699: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 30, 2023
@GoeLin
Copy link
Member

GoeLin commented Nov 30, 2023

Pre-submit failure: adlc crashed in build on macos. This is surely unrelated to this change.

@GoeLin
Copy link
Member

GoeLin commented Nov 30, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@GoeLin
8208699: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8208699: remove unneeded imports from runtime tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 4ddc5d7: 8315606: Open source few swing text/html tests
  • ac1764d: 8289511: Improve test coverage for XPath Axes: child
  • 3a3efef: 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry
  • cf544e0: 8214915: CtwRunner misses export for jdk.internal.access
  • 9d4da7c: 8214908: add ctw tests for jdk.jfr and jdk.management.jfr modules
  • 9591e12: 8219475: javap man page needs to be updated
  • 0e29291: 8320884: Bump update version for OpenJDK: jdk-11.0.23

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 30, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Nov 30, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@amosshi
Your change (at version fed7efc) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Nov 30, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

Going to push as commit 3988054.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 4ddc5d7: 8315606: Open source few swing text/html tests
  • ac1764d: 8289511: Improve test coverage for XPath Axes: child
  • 3a3efef: 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry
  • cf544e0: 8214915: CtwRunner misses export for jdk.internal.access
  • 9d4da7c: 8214908: add ctw tests for jdk.jfr and jdk.management.jfr modules
  • 9591e12: 8219475: javap man page needs to be updated
  • 0e29291: 8320884: Bump update version for OpenJDK: jdk-11.0.23

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2023
@openjdk openjdk bot closed this Nov 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@GoeLin @amosshi Pushed as commit 3988054.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8208699 branch December 6, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants