Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity #2310

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Nov 29, 2023

Clean backport of JDK-8320363.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320363 needs maintainer approval

Issue

  • JDK-8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2310/head:pull/2310
$ git checkout pull/2310

Update a local copy of the PR:
$ git checkout pull/2310
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2310

View PR using the GUI difftool:
$ git pr show -t 2310

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2310.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6aa197667ad05bd93adf3afc7b06adbfb2b18a22 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity Nov 29, 2023
@openjdk
Copy link

openjdk bot commented Nov 29, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 29, 2023

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Small, but obvious bug in type profiling on PPC64. Doesn't cause crashes, but unnecessary profile updates. Fix only touches PPC64 files, is very small and applies cleanly. Tested in jdk head and this PR in our nightly tests.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@TheRealMDoerr
8320363: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 30, 2023
@GoeLin
Copy link
Member

GoeLin commented Dec 1, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@GoeLin
8320363: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 3988054: 8208699: remove unneeded imports from runtime tests
  • 4ddc5d7: 8315606: Open source few swing text/html tests
  • ac1764d: 8289511: Improve test coverage for XPath Axes: child
  • 3a3efef: 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry
  • cf544e0: 8214915: CtwRunner misses export for jdk.internal.access
  • 9d4da7c: 8214908: add ctw tests for jdk.jfr and jdk.management.jfr modules
  • 9591e12: 8219475: javap man page needs to be updated

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 1, 2023
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

Going to push as commit 360bab8.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 3988054: 8208699: remove unneeded imports from runtime tests
  • 4ddc5d7: 8315606: Open source few swing text/html tests
  • ac1764d: 8289511: Improve test coverage for XPath Axes: child
  • 3a3efef: 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry
  • cf544e0: 8214915: CtwRunner misses export for jdk.internal.access
  • 9d4da7c: 8214908: add ctw tests for jdk.jfr and jdk.management.jfr modules
  • 9591e12: 8219475: javap man page needs to be updated

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2023
@openjdk openjdk bot closed this Dec 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@TheRealMDoerr Pushed as commit 360bab8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants