Skip to content

8208623: [TESTBUG] runtime/LoadClass/LongBCP.java fails in AUFS file system #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Nov 30, 2023

Backport of JDK-8208623

Note.

  • The diff of the original commit cannot be applied, because the baseline code is different
  • The only issue is import java.io.File; already exists in jdk11u-dev, so we ignored this line when doing manual merge
  • This change can be considered as clean backport because the Semantics is exactly the same

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8208623 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8208623: [TESTBUG] runtime/LoadClass/LongBCP.java fails in AUFS file system (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2315/head:pull/2315
$ git checkout pull/2315

Update a local copy of the PR:
$ git checkout pull/2315
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2315

View PR using the GUI difftool:
$ git pr show -t 2315

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2315.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03d6ab3b09eaa0bc4860fb530d648270149dcfe0 8208623: [TESTBUG] runtime/LoadClass/LongBCP.java fails in AUFS file system Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 30, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@amosshi
8208623: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Dec 1, 2023
Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@amosshi
Copy link
Contributor Author

amosshi commented Dec 12, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Unclean backport. SAP nightlies passed on 2023-11-30.”

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@amosshi
8208623: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8208623: [TESTBUG] runtime/LoadClass/LongBCP.java fails in AUFS file system

Limit the maximal file name length to 242 for AUFS file system

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 7d85ecf: 8202282: [TESTBUG] appcds TestCommon.makeCommandLineForAppCDS() can be removed
  • 7833ea8: 8219585: [TESTBUG] sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java passes trivially when it shouldn't
  • 878c107: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF
  • 9761bc9: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64
  • 04b1f4c: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • 5be448f: 8299494: Test vmTestbase/nsk/stress/except/except011.java failed: ExceptionInInitializerError: target class not found
  • 8b61278: 8054572: [macosx] JComboBox paints the border incorrectly
  • d08a3d0: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 0ce4c5e: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 420a68e: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
  • ... and 44 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 12, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 13, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

@amosshi
Your change (at version 303c965) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

Going to push as commit ccc74bb.
Since your change was applied there have been 54 commits pushed to the master branch:

  • 7d85ecf: 8202282: [TESTBUG] appcds TestCommon.makeCommandLineForAppCDS() can be removed
  • 7833ea8: 8219585: [TESTBUG] sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java passes trivially when it shouldn't
  • 878c107: 8300269: The selected item in an editable JComboBox with titled border is not visible in Aqua LAF
  • 9761bc9: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64
  • 04b1f4c: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
  • 5be448f: 8299494: Test vmTestbase/nsk/stress/except/except011.java failed: ExceptionInInitializerError: target class not found
  • 8b61278: 8054572: [macosx] JComboBox paints the border incorrectly
  • d08a3d0: 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case
  • 0ce4c5e: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 420a68e: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
  • ... and 44 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2023
@openjdk openjdk bot closed this Dec 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

@MBaesken @amosshi Pushed as commit ccc74bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8208623 branch December 16, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants