Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case #2331

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 4, 2023


Progress

  • Change must not contain extraneous whitespace
  • JDK-8314883 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2331/head:pull/2331
$ git checkout pull/2331

Update a local copy of the PR:
$ git checkout pull/2331
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2331

View PR using the GUI difftool:
$ git pr show -t 2331

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2331.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 97b94cb1cdeba00f4bba7326a300c0336950f3ec 8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8314883: Java_java_util_prefs_FileSystemPreferences_lockFile0 write result errno in missing case

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 5, 2023
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2023

Going to push as commit d08a3d0.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 0ce4c5e: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 420a68e: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
  • 05bb69d: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
  • ad68a72: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
  • af09671: 8301310: The SendRawSysexMessage test may cause a JVM crash
  • 325a93f: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
  • ed2dbac: 8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out
  • e63499d: 8217475: Unexpected StackOverflowError in "process reaper" thread
  • 3ea286a: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 31064b1: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM
  • ... and 16 more: https://git.openjdk.org/jdk11u-dev/compare/d4fcded47a0f3b8a58fb5cab53b34fab80dfcbc3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2023
@openjdk openjdk bot closed this Dec 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 11, 2023

@MBaesken Pushed as commit d08a3d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant