Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR #2334

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 5, 2023

Backport of JDK-8251904

Note the diff for file test/hotspot/jtreg/vmTestbase/nsk/sysdict/share/SysDictTest.java cannot be applied automatically

  • Because the baseline of Copyright (c) year section are different
  • This line has been merged manually
  • So the change can be considered clear

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8251904 needs maintainer approval

Issue

  • JDK-8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2334/head:pull/2334
$ git checkout pull/2334

Update a local copy of the PR:
$ git checkout pull/2334
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2334

View PR using the GUI difftool:
$ git pr show -t 2334

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2334.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7ca053de218bf76ea06bbeed860d142db381ca53 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Dec 6, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Clean backort. SAP nightlies passed on 2023-12-05.”

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@amosshi
8251904: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • 3b2d165: 8186610: move ModuleUtils to top-level testlibrary
  • 1080258: 8218754: JDK-8068225 regression in JDIBreakpointTest
  • 04d2033: 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java
  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java
  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • ... and 19 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 6, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 6, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@amosshi
Your change (at version 07471bb) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 7, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit c77e538.
Since your change was applied there have been 33 commits pushed to the master branch:

  • 050bbdb: 8225471: Test utility jdk.test.lib.util.FileUtils.areAllMountPointsAccessible needs to tolerate duplicates
  • c0575b8: 8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written."
  • 8191f62: 8316030: Update Libpng to 1.6.40
  • db1d944: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • 3b2d165: 8186610: move ModuleUtils to top-level testlibrary
  • ... and 23 more: https://git.openjdk.org/jdk11u-dev/compare/be01e6e792dea3da59f3c6b5f14882f678dcc1ce...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@GoeLin @amosshi Pushed as commit c77e538.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8251904 branch December 7, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants