Skip to content

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Dec 5, 2023

I backport this for parity with 11.0.23-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8237777 needs maintainer approval

Issue

  • JDK-8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written." (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2339/head:pull/2339
$ git checkout pull/2339

Update a local copy of the PR:
$ git checkout pull/2339
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2339

View PR using the GUI difftool:
$ git pr show -t 2339

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2339.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1f31afd855b60fea52257e3ce7d274afe7005b26 8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written." Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written."

Remove the unneeded and possibly misleading message.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • 3b2d165: 8186610: move ModuleUtils to top-level testlibrary
  • 1080258: 8218754: JDK-8068225 regression in JDIBreakpointTest
  • 04d2033: 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java
  • 7dfd132: 8226706: (se) Reduce the number of outer loop iterations on Windows in java/nio/channels/Selector/RacyDeregister.java
  • d4fcded: 8282665: [REDO] ByteBufferTest.java: replace endless recursion with RuntimeException in void ck(double x, double y)
  • 4245e3c: 8255277: randomDelay in DrainDeadlockT and LoggingDeadlock do not randomly delay
  • ... and 9 more: https://git.openjdk.org/jdk11u-dev/compare/360bab8a084b2c7b76af47245dd036c2c2c761c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 6, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

Going to push as commit c0575b8.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 8191f62: 8316030: Update Libpng to 1.6.40
  • db1d944: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
  • 2d7dd47: 8207214: Broken links in JDK API serialized-form page
  • e4504a4: Merge
  • 09b402a: 8319187: Add three eMudhra emSign roots
  • e793bdd: 8234309: LFGarbageCollectedTest.java fails with parse Exception
  • 082fb9c: 8219612: [TESTBUG] compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host
  • 3b2d165: 8186610: move ModuleUtils to top-level testlibrary
  • 1080258: 8218754: JDK-8068225 regression in JDIBreakpointTest
  • 04d2033: 8273803: Zero: Handle "zero" variant in CommandLineOptionTest.java
  • ... and 12 more: https://git.openjdk.org/jdk11u-dev/compare/360bab8a084b2c7b76af47245dd036c2c2c761c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2023
@openjdk openjdk bot closed this Dec 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@luchenlin Pushed as commit c0575b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant