Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251254: Add automated test for fix done in JDK-8218472 #234

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Aug 12, 2021

Clean backport to match 11.0.13-oracle.

Additional testing:

  • New test passes on Linux/GTK3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8251254: Add automated test for fix done in JDK-8218472

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/234/head:pull/234
$ git checkout pull/234

Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 234

View PR using the GUI difftool:
$ git pr show -t 234

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/234.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 12, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 8bf5b1d18b951df92f47661a124723678979cf04 8251254: Add automated test for fix done in JDK-8218472 Aug 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 12, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251254: Add automated test for fix done in JDK-8218472

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bdfc60a: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 12, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Aug 13, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

Going to push as commit 1a7a9d8.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 0459ea5: 8251166: Add automated testcases for changes done in JDK-8214112
  • b117ecc: 8214195: Align stdout messages in test/jdk/java/math/BigInteger/PrimitiveConversionTests.java
  • bdfc60a: 8270137: Kerberos Credential Retrieval from Cache not Working in Cross-Realm Setup

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Aug 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 13, 2021

@shipilev Pushed as commit 1a7a9d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8251254 branch Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant