Skip to content

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Dec 7, 2023

I backport this for parity with 11.0.23-oracle.

Only the position is not same in ProblemList, so make it clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8068225 needs maintainer approval

Issue

  • JDK-8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2343/head:pull/2343
$ git checkout pull/2343

Update a local copy of the PR:
$ git checkout pull/2343
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2343

View PR using the GUI difftool:
$ git pr show -t 2343

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2343.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9bc10ee9bf5c47d30b81500f38971ab6ebc4ac6d 8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 7, 2023
@openjdk
Copy link

openjdk bot commented Dec 7, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2023

Webrevs

@luchenlin
Copy link
Contributor Author

/clean

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

@luchenlin This backport pull request is already marked as clean

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • e63499d: 8217475: Unexpected StackOverflowError in "process reaper" thread
  • 3ea286a: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 31064b1: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM
  • 8a390c8: 8281717: Cover logout method for several LoginModule
  • a9536ae: 8226905: unproblem list applications/ctw/modules/* tests on windows
  • c77e538: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 050bbdb: 8225471: Test utility jdk.test.lib.util.FileUtils.areAllMountPointsAccessible needs to tolerate duplicates
  • c0575b8: 8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written."
  • 8191f62: 8316030: Update Libpng to 1.6.40
  • db1d944: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
  • ... and 20 more: https://git.openjdk.org/jdk11u-dev/compare/360bab8a084b2c7b76af47245dd036c2c2c761c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 8, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2023

Going to push as commit ed2dbac.
Since your change was applied there have been 30 commits pushed to the master branch:

  • e63499d: 8217475: Unexpected StackOverflowError in "process reaper" thread
  • 3ea286a: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 31064b1: 8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM
  • 8a390c8: 8281717: Cover logout method for several LoginModule
  • a9536ae: 8226905: unproblem list applications/ctw/modules/* tests on windows
  • c77e538: 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR
  • 050bbdb: 8225471: Test utility jdk.test.lib.util.FileUtils.areAllMountPointsAccessible needs to tolerate duplicates
  • c0575b8: 8237777: "Dumping core ..." is shown despite claiming that "# No core dump will be written."
  • 8191f62: 8316030: Update Libpng to 1.6.40
  • db1d944: 8281149: (fs) java/nio/file/FileStore/Basic.java fails with java.lang.RuntimeException: values differ by more than 1GB
  • ... and 20 more: https://git.openjdk.org/jdk11u-dev/compare/360bab8a084b2c7b76af47245dd036c2c2c761c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2023
@openjdk openjdk bot closed this Dec 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@luchenlin Pushed as commit ed2dbac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant