Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289948: Improve test coverage for XPath functions: Node Set Functions #2361

Closed
wants to merge 3 commits into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 13, 2023

Backport of JDK-8289948

  • Clean Backport

Tests

  • PR - All checks have passed
  • SAP nightlies passed on 2023-12-21,22

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8289948 needs maintainer approval

Issue

  • JDK-8289948: Improve test coverage for XPath functions: Node Set Functions (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2361/head:pull/2361
$ git checkout pull/2361

Update a local copy of the PR:
$ git checkout pull/2361
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2361

View PR using the GUI difftool:
$ git pr show -t 2361

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2361.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 57bf603b7332db86c39680d16b78f94a904daf46 8289948: Improve test coverage for XPath functions: Node Set Functions Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Dec 18, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2023-12-21”

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@amosshi
8289948: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 18, 2023
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clean. You had to replace the text block String DTD. Looks correct.

@amosshi
Copy link
Contributor Author

amosshi commented Dec 22, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Unclean backport. SAP nightlies passed on 2023-12-21”

@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@amosshi
8289948: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Dec 22, 2023
@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289948: Improve test coverage for XPath functions: Node Set Functions

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 53824e5: 8313816: Accessing jmethodID might lead to spurious crashes
  • b6e6d38: 8067651: LevelTransitionTest.java, fix trivial methods levels logic
  • 140e4d0: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • b0257bd: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 4383412: 8257505: nsk/share/test/StressOptions stressTime is scaled in getter but not when printed
  • a269602: 8255743: Relax SIGFPE match in in runtime/ErrorHandling/SecondaryErrorTest.java
  • 3212030: 8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test
  • 9505906: 8207211: [TESTBUG] Remove excessive output from CDS/AppCDS tests
  • 02df756: 8320001: javac crashes while adding type annotations to the return type of a constructor
  • 995d620: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/bd5ef736d6c776dc5cd5e38cc6bfd16d469fbb66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 22, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 22, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 22, 2023
@openjdk
Copy link

openjdk bot commented Dec 22, 2023

@amosshi
Your change (at version 57b564f) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Dec 23, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 23, 2023

Going to push as commit 92534aa.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 53824e5: 8313816: Accessing jmethodID might lead to spurious crashes
  • b6e6d38: 8067651: LevelTransitionTest.java, fix trivial methods levels logic
  • 140e4d0: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • b0257bd: 8166554: Avoid compilation blocking in OverloadCompileQueueTest.java
  • 4383412: 8257505: nsk/share/test/StressOptions stressTime is scaled in getter but not when printed
  • a269602: 8255743: Relax SIGFPE match in in runtime/ErrorHandling/SecondaryErrorTest.java
  • 3212030: 8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test
  • 9505906: 8207211: [TESTBUG] Remove excessive output from CDS/AppCDS tests
  • 02df756: 8320001: javac crashes while adding type annotations to the return type of a constructor
  • 995d620: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/bd5ef736d6c776dc5cd5e38cc6bfd16d469fbb66...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 23, 2023
@openjdk openjdk bot closed this Dec 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 23, 2023
@openjdk
Copy link

openjdk bot commented Dec 23, 2023

@GoeLin @amosshi Pushed as commit 92534aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8289948 branch December 25, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants