Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library #2365

Closed
wants to merge 3 commits into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 13, 2023

Backport of JDK-8301846

  • Clean Backport (git apply succeeded, no manual edit), although the clean label was not added automatically

Tests

  • Local test on Windows laptop - passed
  • PR: All checks have passed
  • SAP nightlies passed on 2023-12-21 for darwinintel64 and darwinaarch64
  • SAP nightlies passed on 2023-12-22,23,24

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301846 needs maintainer approval

Issue

  • JDK-8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2365/head:pull/2365
$ git checkout pull/2365

Update a local copy of the PR:
$ git checkout pull/2365
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2365

View PR using the GUI difftool:
$ git pr show -t 2365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2365.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 613a3cc6896ef3c3f836d44de9b2fb05beba6e72 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 22, 2023

Hi @amosshi, did you run this test?

@openjdk openjdk bot removed the clean label Dec 25, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 25, 2023

Hi @amosshi, did you run this test?

The test succeeded on Windows Laptop:

  • Edition: Windows 11 Enterprise
  • Version: 22H2
  • OS Build: 22621.2861
  • Experience: Windows Feature Experience Pack 1000.22681.1000.0

@openjdk
Copy link

openjdk bot commented Dec 26, 2023

@amosshi
8301846: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Dec 26, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 29, 2023

/approval request “Backporting for parity with jdk 11.0.23-oracle. Unclean back port. SAP nightlies passed on 2023-12-24”

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@amosshi
8301846: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Dec 29, 2023
@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • e55ee09: 8322752: [11u] GetStackTraceAndRetransformTest.java is failing assert
  • 96057c1: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • d232723: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • 879f7cf: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/bd5ef736d6c776dc5cd5e38cc6bfd16d469fbb66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 29, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 30, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 30, 2023
@openjdk
Copy link

openjdk bot commented Dec 30, 2023

@amosshi
Your change (at version b90cd1c) is now ready to be sponsored by a Committer.

@MBaesken
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 30, 2023

Going to push as commit d94b3f8.
Since your change was applied there have been 36 commits pushed to the master branch:

  • e55ee09: 8322752: [11u] GetStackTraceAndRetransformTest.java is failing assert
  • 96057c1: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • a6fc00a: 8269025: jsig/Testjsig.java doesn't check exit code
  • 43d4c50: 8271094: runtime/duplAttributes/DuplAttributesTest.java doesn't check exit code
  • 823b65a: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 234d2f0: 8316028: Update FreeType to 2.13.2
  • b31ee7f: 8253820: Save test images and dumps with timestamps from client sanity suite
  • f308f3e: 8198668: MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001/TestDescription.java still failing
  • d232723: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • 879f7cf: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • ... and 26 more: https://git.openjdk.org/jdk11u-dev/compare/bd5ef736d6c776dc5cd5e38cc6bfd16d469fbb66...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 30, 2023
@openjdk openjdk bot closed this Dec 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 30, 2023
@openjdk
Copy link

openjdk bot commented Dec 30, 2023

@MBaesken @amosshi Pushed as commit d94b3f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8301846 branch December 30, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants