Skip to content

8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Dec 14, 2023

Backport of JDK-8180266

Unclean Backport:

  • test/jdk/sun/security/provider/KeyStore/DKSTest.java
    • The Copyright year line basement are different, merged manually
    • This line does not affect application logic, so can be considered as Clean backport

Tests

  • Test Succeeded in local Dev Apple M1 Laptop
  • PR: All checks have passed
  • SAP nightlies passed on 2023-12-19

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8180266 needs maintainer approval

Issue

  • JDK-8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2381/head:pull/2381
$ git checkout pull/2381

Update a local copy of the PR:
$ git checkout pull/2381
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2381/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2381

View PR using the GUI difftool:
$ git pr show -t 2381

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2381.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2023

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7f313b0cef7d0e9732beed6c61298815306531e0 8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test Dec 14, 2023
@openjdk
Copy link

openjdk bot commented Dec 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 14, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Dec 15, 2023

/approval request “Backporting for parity with jdk 11.0.22-oracle. No risk, test fix. Unclean backport. SAP nightlies passed on 2023-12-19”

@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@amosshi
8180266: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Dec 15, 2023
@GoeLin
Copy link
Member

GoeLin commented Dec 18, 2023

/clean

@openjdk openjdk bot added the clean label Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8180266: Convert sun/security/provider/KeyStore/DKSTest.sh to Java Jtreg Test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

  • 93f7a8c: 8320798: Console read line with zero out should zero out underlying buffer
  • dc374f6: 8322178: Error. can't find jdk.testlibrary.SimpleSSLContext in test directory or libraries
  • 4470c0a: 8320597: RSA signature verification fails on signed data that does not encode params correctly
  • bd5ef73: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • f06fe1c: 8318951: Additional negative value check in JPEG decoding
  • 0107cb2: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 5243535: 8306996: Open source Swing MenuItem related tests
  • da4bfa7: 8307130: Open source few Swing JMenu tests
  • 57abf97: 8305505: NPE in javazic compiler
  • 1ed87b6: 8306072: Open source several AWT MouseInfo related tests
  • ... and 45 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 18, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Dec 18, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@amosshi
Your change (at version 196d566) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 18, 2023

Going to push as commit 3212030.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 9505906: 8207211: [TESTBUG] Remove excessive output from CDS/AppCDS tests
  • 02df756: 8320001: javac crashes while adding type annotations to the return type of a constructor
  • 995d620: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout
  • 93f7a8c: 8320798: Console read line with zero out should zero out underlying buffer
  • dc374f6: 8322178: Error. can't find jdk.testlibrary.SimpleSSLContext in test directory or libraries
  • 4470c0a: 8320597: RSA signature verification fails on signed data that does not encode params correctly
  • bd5ef73: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • f06fe1c: 8318951: Additional negative value check in JPEG decoding
  • 0107cb2: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 5243535: 8306996: Open source Swing MenuItem related tests
  • ... and 48 more: https://git.openjdk.org/jdk11u-dev/compare/e793bdd174ad976f567d0d911db42f67f6d7e59d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 18, 2023
@openjdk openjdk bot closed this Dec 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 18, 2023
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

@phohensee @amosshi Pushed as commit 3212030.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8180266 branch December 25, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants